Remove visibility controls for models in the model configuration window#314598
Merged
Conversation
vritant24
commented
May 6, 2026
| } | ||
|
|
||
|
|
||
| /** Gutter column styling **/ |
Member
Author
There was a problem hiding this comment.
removed the gutter as it had the visibility controls, which are no longer needed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the user-facing “visibility” (hide/show) control for language models from the model configuration/management UI and the underlying storage/preferences plumbing, so that the chat model picker no longer depends on per-model hidden state.
Changes:
- Removed the model picker visibility preference API and storage handling from
LanguageModelsService. - Simplified the chat “Manage Models” UI by dropping visibility filters, visibility grouping, and hide/show actions.
- Updated/removed related tests and adjusted layout/styling for the management table after dropping the visibility gutter column.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/languageModels.ts | Updates the null service stub to match the removed visibility preference API. |
| src/vs/workbench/contrib/chat/test/common/languageModels.test.ts | Removes tests that validated model-picker visibility preference storage behavior; updates event wiring in remaining tests. |
| src/vs/workbench/contrib/chat/test/browser/chatManagement/chatModelsWidget.test.ts | Updates widget hover tests to account for removal of visible on ILanguageModel. |
| src/vs/workbench/contrib/chat/test/browser/chatManagement/chatModelsViewModel.test.ts | Removes tests for visibility filtering/grouping and visibility mutation APIs. |
| src/vs/workbench/contrib/chat/common/languageModels.ts | Removes visibility preference persistence + overrides, and stops activating vendors based on stored picker preferences. |
| src/vs/workbench/contrib/chat/browser/chatManagement/media/chatModelsWidget.css | Adjusts table padding/column targeting after removing the gutter/visibility column; removes hidden-row styling. |
| src/vs/workbench/contrib/chat/browser/chatManagement/chatModelsWidget.ts | Removes visibility filters/actions and gutter renderer; moves collapse UI into the name column; updates ARIA labeling accordingly. |
| src/vs/workbench/contrib/chat/browser/chatManagement/chatModelsViewModel.ts | Removes the visible model field, visibility filtering/grouping, and visibility mutation methods. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts | Updates the models section description text to remove “Select models for use…” wording. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 3
vijayupadya
previously approved these changes
May 6, 2026
vritant24
changed the title
vijayupadya
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today:
/modelsin the chat windowBeing able to toggle visibility is no longer necessary with those available.
Users can also run into an interesting problem where searching for models don't show up because they are
hiddenin the chat window model picker, but are searchable in the model configuration window.This PR removes controlling the visibility of models entirely, allowing all models to be available in the model picker.