Skip to content

Tweak markdown reopen command wording and icon#314583

Open
mjbvz wants to merge 2 commits intomainfrom
dev/mjbvz/only-gopher
Open

Tweak markdown reopen command wording and icon#314583
mjbvz wants to merge 2 commits intomainfrom
dev/mjbvz/only-gopher

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented May 5, 2026

Trying to align these with the commands from core

Trying to align these with the commands from core
Copilot AI review requested due to automatic review settings May 5, 2026 23:37
@mjbvz mjbvz enabled auto-merge May 5, 2026 23:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the Markdown extension’s “reopen” command labels and iconography with equivalent core workbench wording/icons, and avoids showing the reopen-to-text action in custom-editor diff contexts where core already provides a “Reopen as Text” affordance.

Changes:

  • Update Markdown command titles to “Reopen as Preview”, “Reopen as Text”, and “Toggle Preview”.
  • Change markdown.reopenAsSource command icon from $(file-text) to $(file-code).
  • Gate markdown.reopenAsSource title-bar menu entries to not appear for custom-editor text diff scenarios (!activeCustomEditorTextDiff).
Show a summary per file
File Description
extensions/markdown-language-features/package.nls.json Updates localized command titles for reopen/toggle preview commands to match core wording.
extensions/markdown-language-features/package.json Updates command icon and tightens menu when clauses to avoid showing reopen-to-text in custom-editor diff contexts.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Screenshot Changes

Base: c75215c0 Current: adc041ea

Changed (15)

chat/input/chatInput/Default/Dark
Before After
before after
chat/input/chatInput/Default/Light
Before After
before after
chat/input/chatInput/WithArtifacts/Dark
Before After
before after
chat/input/chatInput/WithArtifacts/Light
Before After
before after
chat/input/chatInput/WithFileChanges/Dark
Before After
before after
chat/input/chatInput/WithFileChanges/Light
Before After
before after
chat/input/chatInput/WithTodos/Dark
Before After
before after
chat/input/chatInput/WithTodos/Light
Before After
before after
chat/input/chatInput/WithTodosAndFileChanges/Dark
Before After
before after
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
Before After
before after
chat/input/chatInput/WithArtifactsAndFileChanges/Light
Before After
before after
chat/input/chatInput/Full/Dark
Before After
before after
chat/input/chatInput/Full/Light
Before After
before after
chat/widget/chatWidget/PendingToolApproval/Light
Before After
before after
chat/widget/chatWidget/MultiTurn/Light
Before After
before after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants