Fix Customizations view a11y: Home button focus + tile aria labels#314535
Open
meganrogge wants to merge 1 commit intomainfrom
Open
Fix Customizations view a11y: Home button focus + tile aria labels#314535meganrogge wants to merge 1 commit intomainfrom
meganrogge wants to merge 1 commit intomainfrom
Conversation
Contributor
Screenshot ChangesBase: Changed (10)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Full/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Full/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/MultiTurn/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility in the AI Customizations management UI by ensuring focus moves into the welcome content when navigating “Home/Overview”, and by adjusting list tile aria labels to make title vs. description more clearly announced by screen readers.
Changes:
- Move focus into the welcome page after
showWelcomePage()navigation. - Update aria labels to separate title/description with a period for a clearer screen-reader pause.
- Include plugin descriptions in plugin list tile aria labels (previously name-only).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts | Adds description to plugin item aria labels and uses “. ” separator. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts | Changes bridged MCP server aria label separator from “, ” to “. ”. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts | Calls welcomePage.focus() when navigating back to the welcome page. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts | Changes item aria label separator from “, ” to “. ” for clearer announcements. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
Comment on lines
+604
to
+607
| const description = element.item.description; | ||
| return description | ||
| ? localize('pluginItemAriaLabel', "{0}. {1}", element.item.name, description) | ||
| : element.item.name; |
Comment on lines
692
to
694
| const nameAndDesc = entry.item.description | ||
| ? localize('itemAriaLabel', "{0}, {1}", entry.item.name, entry.item.description) | ||
| ? localize('itemAriaLabel', "{0}. {1}", entry.item.name, entry.item.description) | ||
| : entry.item.name; |
roblourens
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314173 and #314089.
#314173 — Home button doesn't focus content
showWelcomePage()now callswelcomePage.focus()after navigating, so activating the 🏠 Home button moves focus into the welcome page (the prompt input) instead of leaving focus on the button.#314089 — Screen reader: title vs. description unclear
For list tiles in the agents/skills/instructions, MCP, and plugins lists, the aria label joined name and description with a comma — screen readers (e.g. Narrator) read "Ask answers questions without making changes" with no clear pause between title and description.
,separator with.in the aria labels to produce a longer screen-reader pause.