Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR broadens xAI (Grok) model detection from the specific grok-code* family to all grok* families and uses that shared classification to adjust model capabilities, prompts, and Responses API request shaping in the Copilot extension.
Changes:
- Introduces
isXAIFamily()(grok*) and uses it to drive replace-string edit-tool capability decisions. - Disables Responses API
reasoning.summaryandreasoning.effortconfiguration for xAI models. - Updates agent prompt selection / CLI prompt tagging and disables the todo-list tool for xAI models.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/endpoint/node/responsesApi.ts | Uses new capability helpers to gate reasoning summary/effort in Responses API request bodies (notably for xAI). |
| extensions/copilot/src/platform/endpoint/common/chatModelCapabilities.ts | Adds isXAIFamily() and new reasoning capability helpers; updates replace-string capability checks to use xAI family detection. |
| extensions/copilot/src/extension/prompts/node/agent/xAIPrompts.tsx | Broadens prompt resolver matching from grok-code* to grok* and renames the default Grok prompt class. |
| extensions/copilot/src/extension/prompts/node/agent/copilotCLIPrompt.tsx | Switches Grok detection to isXAIFamily() for deciding whether to emit the user_query tag. |
| extensions/copilot/src/extension/intents/node/agentIntent.ts | Switches xAI detection to isXAIFamily() to disable the todo-list tool for Grok models. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 1
Contributor
Screenshot ChangesBase: Changed (10)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Default/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/MultiTurn/Light
| Before | After |
|---|---|
 |
 |
pwang347
added
~requires-eval-assessment
Contributor
|
⏳ Queued vscode build for
|
Member
Author
|
~requires-eval-assessment terminalbench2 grok-4.3 |
pwang347
added
the
~requires-eval-assessment
Contributor
|
⏳ Queued vscode build for
|
pwang347
removed
the
~requires-eval-assessment
Member
Author
|
~requires-eval-assessment vscbench grok-4.3 |
pwang347
added
the
~requires-eval-assessment
Contributor
|
⏳ Queued vscode build for
|
pwang347
removed
the
~requires-eval-assessment
Member
Author
|
~requires-eval-assessment swebench.litmus grok-4.3 |
pwang347
added
the
~requires-eval-assessment
Contributor
|
⏳ Queued vscode build for
|
Contributor
|
🚀 Queued eval-assessment publish build for
|
Contributor
|
🔬 Queued eval-assessment benchmark for
Results will be posted back here when the run completes. |
Contributor
|
✅ Eval-assessment build published.
|
vs-code-engineering
Bot
removed
the
~requires-eval-assessment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.