Conversation
There was a problem hiding this comment.
Pull request overview
Updates terminal-related dependency/documentation to align with the latest bundled PTY/conpty components.
Changes:
- Bumps
node-ptyfrom^1.2.0-beta.10to^1.2.0-beta.12in both the main and remote (REH) packages, including lockfiles. - Updates the
terminal.integrated.windowsUseConptyDllsetting description to reference the newer bundledconpty.dllversion.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts | Updates the user-facing setting description for the bundled conpty.dll version. |
| package.json | Bumps node-pty dependency version used by the main product build. |
| package-lock.json | Updates lockfile entries for node-pty@1.2.0-beta.12. |
| remote/package.json | Bumps node-pty dependency version used by the remote server/REH package. |
| remote/package-lock.json | Updates remote lockfile entries for node-pty@1.2.0-beta.12. |
Files not reviewed (1)
- remote/package-lock.json: Language not supported
| this._queueProcessExit(); | ||
| })); | ||
| this._sendProcessId(ptyProcess.pid); | ||
| // node-pty >= 1.2.0-beta.11 defers conptyNative.connect() on Windows, so |
There was a problem hiding this comment.
was getting test failure so trying to see if these would fix it.
I dont like how we are making pid as non-readonly though :/
There was a problem hiding this comment.
@Tyriar With microsoft/node-pty#885 (node-pty beta 11 which hasnt been in VS Code yet),
node-pty defers conptyNative.connect() . So instead of connecting immediately and having valid pid, we just get zero until worker is ready and connection is complete?
The thing is... that lead to test failing since
Do you think 27f4805 is the right way to go about this?
There was a problem hiding this comment.
@deepak1556 Wondering your thoughts here as well! Thanks
This reverts commit c5d9064.
…t()" This reverts commit ded49ad.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TyriarMatched files:
|
Take microsoft/node-pty#898 for #241978