Skip to content

Conversation

@joshspicer
Copy link
Member

fixes #290874

Copilot AI review requested due to automatic review settings January 27, 2026 21:58
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes the agent status indicators (unread and in-progress session counts) respect the chat.viewSessions.enabled configuration setting, addressing user feedback that these indicators persist even when sessions are disabled.

Changes:

  • Updated documentation for chat.agentsControl.enabled setting to explain the dependency on chat.viewSessions.enabled
  • Modified the agent title bar status widget to conditionally render session indicators based on the chat.viewSessions.enabled setting
  • Added the new configuration to the widget's state tracking and re-render logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Updated configuration description to document that session indicators require chat.viewSessions.enabled
src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts Added logic to hide unread and in-progress indicators when sessions are disabled, updated configuration change listener, and included the setting in render state tracking
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts:262

  • Inconsistent boolean configuration check pattern. Other boolean configurations in this file (lines 260-261) use === true, but this uses !== false. For consistency with the surrounding code, consider using === true instead of !== false.
			const viewSessionsEnabled = this.configurationService.getValue<boolean>(ChatConfiguration.ChatViewSessionsEnabled) !== false;

@joshspicer joshspicer enabled auto-merge (squash) January 27, 2026 22:32
@joshspicer joshspicer merged commit 49b3376 into main Jan 27, 2026
27 of 28 checks passed
@joshspicer joshspicer deleted the joshspicer/290874 branch January 27, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should chat.viewSessions.enabled sessions disable the status indicators

3 participants