Skip to content

Fix settings editor double render when opening with filter #290607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −2
Draft

Fix settings editor double render when opening with filter #290607

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
424dcb6
Initial plan
Copilot Jan 26, 2026
82003f4
Fix settings editor double render when opening with filter
Copilot Jan 26, 2026
241a8ed
Add skipInitialSearch guard to prevent recursion
Copilot Jan 26, 2026
03e580b
Use searchWidget.getValue() for better query validation
Copilot Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,7 +1464,7 @@ export class SettingsEditor2 extends EditorPane {
this.settingsOrderByTocIndex = this.createSettingsOrderByTocIndex(resolvedSettingsRoot);
}

private async onConfigUpdate(keys?: ReadonlySet<string>, forceRefresh = false, triggerSearch = false): Promise<void> {
private async onConfigUpdate(keys?: ReadonlySet<string>, forceRefresh = false, triggerSearch = false, skipInitialSearch = false): Promise<void> {
if (keys && this.settingsTreeModel) {
return this.updateElementsByKey(keys);
}
Expand Down Expand Up @@ -1634,6 +1634,14 @@ export class SettingsEditor2 extends EditorPane {
return await this.onSearchInputChanged(false);
}

// If there's a query present (e.g., opening with a filter like @tag:accessibility),
// trigger the search before rendering to avoid showing all settings first
if (!skipInitialSearch && this.searchWidget.getValue() && !this.searchResultModel) {
await this.onSearchInputChanged(true);
// onSearchInputChanged already handles refreshing TOC and rendering the tree
return;
}

this.refreshTOCTree();
this.renderTree(undefined, forceRefresh);

Expand Down Expand Up @@ -1863,7 +1871,7 @@ export class SettingsEditor2 extends EditorPane {
}

if (showAdvanced !== this.viewState.tagFilters?.has(ADVANCED_SETTING_TAG)) {
await this.onConfigUpdate();
await this.onConfigUpdate(undefined, false, false, true);
}

this.settingsTargetsWidget.updateLanguageFilterIndicators(this.viewState.languageFilter);
Expand Down