Respect revealIfOpen setting when opening editors with Quick Open#134478
Closed
mkcode wants to merge 1 commit intomicrosoft:mainfrom
Closed
Respect revealIfOpen setting when opening editors with Quick Open#134478mkcode wants to merge 1 commit intomicrosoft:mainfrom
mkcode wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
|
This is by design: the list of editors in quick pick should focus on the editor you pick in the right group picked. Consider this picker like editor tabs: if you click on an editor tab you would not expect another editor to open, irrespective of the reveal if opened setting. |
Author
Author
|
Closing this PR in favor of #134525 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where there is inconsistent behavior between opening file and editors when using Quick Open with respecting the
workbench.editor.revealIfOpensetting.Before this PR:
workbench.editor.revealIfOpensetting.workbench.editor.revealIfOpensetting.After this PR:
workbench.editor.revealIfOpensetting.workbench.editor.revealIfOpensettingThis PR is tangentially related to #94705 where there has been lots of discussion.
I made an alternative implementation which introduces a unique setting
workbench.editor.alwaysOpenInActiveGroupFromQuickOpenhere: 02d4d73 But IMO, it is more clean to use the existing setting to create consistent behavior in this case, rather than introducing a new more granular setting.