Skip to content

fix: change stop hook from blocking to warning to prevent auto-commits #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eleanorjboyd merged 1 commit into from
Apr 14, 2026
+5 −6
Merged

fix: change stop hook from blocking to warning to prevent auto-commits #1451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/hooks/scripts/stop_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,12 @@ def main() -> int:
response = {
"hookSpecificOutput": {
"hookEventName": "Stop",
"decision": "block",
"decision": "warn",
"reason": (
"You have uncommitted TypeScript changes. "
"Before finishing, use the run-pre-commit-checks skill "
"Before finishing, consider using the run-pre-commit-checks skill "
"or manually run: npm run lint && npm run compile-tests && npm run unittest. "
"If checks pass and changes are ready, commit them. "
"If this session is just research/exploration, you can proceed without committing."
"Ask the user whether to commit or leave changes uncommitted."
),
}
}
Expand All @@ -128,10 +127,10 @@ def main() -> int:
response = {
"hookSpecificOutput": {
"hookEventName": "Stop",
"decision": "block",
"decision": "warn",
"reason": (
"You have staged changes that haven't been committed. "
"Either commit them with a proper message or unstage them before finishing."
"Ask the user whether to commit them or leave them staged."
),
}
}
Expand Down
Loading