Skip to content

Remove stale persistentState #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonykim1 merged 1 commit into from
Dec 13, 2025
Merged

Remove stale persistentState #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/features/terminal/shells/common/shellUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { PythonCommandRunConfiguration, PythonEnvironment } from '../../../../api';
import { traceInfo } from '../../../../common/logging';
import { getGlobalPersistentState } from '../../../../common/persistentState';
import { timeout } from '../../../../common/utils/asyncUtils';
import { isWindows } from '../../../../common/utils/platformUtils';
import { activeTerminalShellIntegration } from '../../../../common/window.apis';
Expand All @@ -9,8 +8,6 @@ import { ShellConstants } from '../../../common/shellConstants';
import { quoteArgs } from '../../../execution/execUtils';
import { SHELL_INTEGRATION_POLL_INTERVAL, SHELL_INTEGRATION_TIMEOUT } from '../../utils';

export const SHELL_INTEGRATION_STATE_KEY = 'shellIntegration.enabled';

function getCommandAsString(command: PythonCommandRunConfiguration[], shell: string, delimiter: string): string {
const parts = [];
for (const cmd of command) {
Expand Down Expand Up @@ -119,10 +116,6 @@ export async function shellIntegrationForActiveTerminal(name: string, profile?:
`SHELL: Shell integration is available on your active terminal, with name ${name} and profile ${profile}. Python activate scripts will be evaluated at shell integration level, except in WSL.`,
);

// Update persistent storage to reflect that shell integration is available
const persistentState = await getGlobalPersistentState();
await persistentState.set(SHELL_INTEGRATION_STATE_KEY, true);

return true;
}
return false;
Expand All @@ -134,7 +127,6 @@ export function isWsl(): boolean {
}

export async function getShellIntegrationEnabledCache(): Promise<boolean> {
const persistentState = await getGlobalPersistentState();
const shellIntegrationInspect =
getConfiguration('terminal.integrated').inspect<boolean>('shellIntegration.enabled');

Expand All @@ -158,7 +150,6 @@ export async function getShellIntegrationEnabledCache(): Promise<boolean> {
}
}

await persistentState.set(SHELL_INTEGRATION_STATE_KEY, shellIntegrationEnabled);
return shellIntegrationEnabled;
}

Expand Down
Loading