Skip to content

fix: use jdtutils to parse uri #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenytang-ms merged 4 commits into from
Nov 17, 2025
Merged

fix: use jdtutils to parse uri #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a535ab1
fix: use jdtutils to parse uri
wenytang-ms Nov 17, 2025
fd0f272
fix: fix copilot comments
wenytang-ms Nov 17, 2025
17d4e0b
fix: update
wenytang-ms Nov 17, 2025
915ad8f
fix: update
wenytang-ms Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,15 +672,13 @@ public static ProjectDependenciesResult getProjectDependencies(List<Object> argu
return new ProjectDependenciesResult(ProjectDependenciesErrorReason.INVALID_URI, fileUri);
}

// Validate URI format
String parsedPath = null;
// Validate URI format using JDTUtils
try {
java.net.URI uri = new java.net.URI(fileUri);
parsedPath = uri.getPath();
if (parsedPath == null) {
return new ProjectDependenciesResult(ProjectDependenciesErrorReason.URI_PARSE_FAILED, parsedPath);
java.net.URI uri = JDTUtils.toURI(fileUri);
if (uri == null) {
return new ProjectDependenciesResult(ProjectDependenciesErrorReason.URI_PARSE_FAILED, fileUri);
}
} catch (java.net.URISyntaxException e) {
} catch (Exception e) {
return new ProjectDependenciesResult(ProjectDependenciesErrorReason.MALFORMED_URI, fileUri);
}

Expand Down
2 changes: 1 addition & 1 deletion ...com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/parser/ContextResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*******************************************************************************
/*******************************************************************************
* Copyright (c) 2018 Microsoft Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
Expand Down
Loading