feat: add getImportClassContent method to collect import class info #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chagong
previously approved these changes
Sep 19, 2025
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java
Outdated
Show resolved
Hide resolved
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java
Show resolved
Hide resolved
chagong
previously approved these changes
Sep 26, 2025
Contributor
|
LGTM based on the test result you pasted. |
testforstephen
previously approved these changes
Sep 26, 2025
Contributor
testforstephen
left a comment
testforstephen
left a comment
There was a problem hiding this comment.
This is a good start to enable the exp first.
There are more cases to cover for the import, we can optimize them later. for example, In Java, all classes in the same package can access each other by default without explicit imports. Also can support the method with package visible or protected modifier.
Contributor
Author
|
Thanks @testforstephen for your suggestion, will update the logic for better user experiment. This PR will be merged after the stable release of the Java mod change. |
wenytang-ms
dismissed stale reviews from testforstephen and chagong
via
6baf10b
chagong
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing against some popular java repo
jbang
Mixin
Velocity
java deps cost - execute java command time cost
pack cost - execute context provider to collect and return context whole time cost