Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions #901

FluoriteCafe-work · 2025-09-03T04:20:29Z

Components for Java engine/dependency upgrade reminder.

FluoriteCafe-work · 2025-09-03T04:26:42Z

@microsoft-github-policy-service agree company="Microsoft"

wangmingliang-ms · 2025-09-03T05:29:21Z

src/views/workspaceNode.ts

-        return Jdtls.getProjects(this.nodeData.uri);
+        const result = await Jdtls.getProjects(this.nodeData.uri);
+        PromotionProvider.getInstance().checkJavaVersion(result);
+        return result;


what if this method is called >1 times?

The loadData function should only handle data retrieval. Performing a Java version validation at the same time as data fetching seems quite unreasonable. This is clearly a "side effect" and should be avoided.

what if this method is called >1 times?

Controls are implemented in a downstream function to prevent repeated notifications.

The loadData function should only handle data retrieval.

I'll seek to move the added logic out of loadData().

I've updated the PR to check Java version on creation of ProjectNode (new ProjectNode(...)) - Java version is related to this type of node. Outside the scope the Java version data is hard to be read (it's saved in a protected property) without touching the property structure of classes.

akaroml

Please detect whether the App Mod ext is active. If it's inactive, no hint should be shown to the users.

akaroml · 2025-09-10T03:38:01Z

package.nls.json

Please only make necessary changes to reduce the size of of the PR. In this file, the only change is the inserted line of:

"contributes.commands.java.view.triggerJavaUpgradeTool": "Upgrade dependencies",

Formatting are restored in c2c4cf6.

akaroml · 2025-09-10T03:39:40Z

src/constants.ts

+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE = "java-engine";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_ENGINE = "Java Engine";
+    export const PROMOTION_DIAGNOSTIC_SOURCE = "Java";
+    export const EARLIEST_JAVA_VERSION_NOT_TO_PROMPT = 21;


LATEST_JAVA_LTS_VERSION

Done in 56084e6.

akaroml · 2025-09-10T03:40:16Z

src/constants.ts


+export namespace Upgrade {
+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE = "java-engine";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_ENGINE = "Java Engine";


Use "java-upgrade-assistant" and "Java Upgrade Assistant" instead.

Changed to java:* to align with the java-upgrade extension.

akaroml · 2025-09-10T03:40:59Z

src/constants.ts

+export namespace Upgrade {
+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE = "java-engine";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_ENGINE = "Java Engine";
+    export const PROMOTION_DIAGNOSTIC_SOURCE = "Java";


"Java Upgrade Assistant"

akaroml · 2025-09-10T03:42:00Z

src/extension.ts

 import * as path from "path";
-import { commands, Diagnostic, Extension, ExtensionContext, extensions, languages,
-    Range, tasks, TextDocument, TextEditor, Uri, window, workspace } from "vscode";
+import {


Please avoid unnecessary changes.

Fixed in c3ee610.

akaroml · 2025-09-10T03:42:25Z

src/syncHandler.ts

            instrumentOperation(ENABLE_AUTO_REFRESH, () => this.enableAutoRefresh())();
        } else {
-            instrumentOperation(DISABLE_AUTO_REFRESH, () => {})();
+            instrumentOperation(DISABLE_AUTO_REFRESH, () => { })();


Avoid unnecessary changes.

akaroml · 2025-09-10T03:42:35Z

src/syncHandler.ts

        } else {
            // in flat view
            if (path.extname(uri.fsPath) === ".java" && node.uri &&
-                    Uri.parse(node.uri).fsPath === path.dirname(uri.fsPath)) {


Avoid unnecessary changes.

akaroml · 2025-09-10T03:56:31Z

src/upgrade/upgradeManager.ts

+        );
+    }
+
+    private async checkUpgradableComponents(folder: WorkspaceFolder) {


Since we are already in Project Explorer, we already know all the dependencies and the version of java runtimes. Can we work with the project metadata directly? wihtout parsing the POM/Gradle files manually? CC @jdneo

akaroml

In general, I wasn't expecting so many code changes. The fat implementation of manually parsing everything is the root cause. As commented, please consider work with the project metadata directly. In the metadata, the runtime version and dependency versions should all be available.

akaroml

In general, I wasn't expecting so many code changes. The fat implementation of manually parsing everything is the root cause. As commented, please consider work with the project metadata directly. In the metadata, the runtime version and dependency versions should all be available.

FluoriteCafe-work · 2025-09-10T06:34:01Z

@akaroml Thanks for the review!

As commented, please consider work with the project metadata directly. In the metadata, the runtime version and dependency versions should all be available.

The code is now working with Jdtls to retrieve all metadata. The extension has already gone through the process once, but it's in a lazy-loading way - only retrieving needed parts (projects and dependencies etc.) when user expands the nodes in tree view. As a result, the PR need to actively call Jdtls by itself to gain a full picture.

src/upgrade/upgradeManager.ts

... to java.dependency.enableDependencyCheckup` as `Diagnostics` is used as a VSCode-specific concept

wangmingliang-ms

LGTM

wangmingliang-ms

LGTM

src/upgrade/display/notificationManager.ts

src/upgrade/upgradeManager.ts

akaroml · 2025-09-16T09:12:45Z

src/upgrade/utility.ts

+        case UpgradeReason.DEPRECATED:
+        case UpgradeReason.END_OF_LIFE:
+        default: {
+            return `The current project is using ${packageDisplayName} ${currentVersion}, which has reached end of life. Do you want to upgrade to ${suggestedVersionName} (${suggestedVersionDescription})?`;


“which has reached end of life”
Can we be explicit about the time of "end of life"?

Fixed by 4d271c1.

Consensus has been reached per offline discussion.

wangmingliang-ms reviewed Sep 3, 2025

View reviewed changes

FluoriteCafe-work changed the title ~~Promote Java Upgrade Tool on projects using old (<21) Java~~ Promote Java Upgrade Tool on projects using old (<21) Java and EOL Spring Sep 3, 2025

FluoriteCafe-work force-pushed the feat/java-upgrade-tool-notification branch from 67e3caa to 6adb53b Compare September 4, 2025 06:34

FluoriteCafe-work changed the title ~~Promote Java Upgrade Tool on projects using old (<21) Java and EOL Spring~~ Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions Sep 8, 2025

FluoriteCafe-work force-pushed the feat/java-upgrade-tool-notification branch 2 times, most recently from 6cd7dd9 to 991c776 Compare September 8, 2025 06:30

This comment was marked as outdated.

Sign in to view

akaroml reviewed Sep 10, 2025

View reviewed changes

akaroml requested a review from jdneo September 10, 2025 03:59

akaroml previously requested changes Sep 10, 2025

View reviewed changes

FluoriteCafe-work added 9 commits September 10, 2025 12:35

feat(jdtls): add PomPath to metadata

3872005

feat: MetadataManager

5574787

feat: add command triggerJavaUpgradeTool

3988de5

feat: NotificationManager

bf7eb04

feat: IssueManager

18be55e

feat(upgradeManager): collect issues on load and workspace folder update

560048c

feat: integrate the flow

0503046

feat: add context menu to open modernization tool

b2406d9

fix: only show modernization menu when related extension is installed

fa488ef

FluoriteCafe-work force-pushed the feat/java-upgrade-tool-notification branch from abfd8c7 to fa488ef Compare September 10, 2025 06:23

FluoriteCafe-work added 2 commits September 10, 2025 14:26

fix: typo

9fbc1c2

chore: fmt

c3ee610

FluoriteCafe-work added 4 commits September 10, 2025 14:50

feat: control reminder display by settings

0e998ba

feat: don't scan when upgrade extension does not exist

3b62771

chore: make class methods static as there are no states here

9043db4

fix: typo

06c14d9

chore: telemetry operation name

5e0f4b0

wangmingliang-ms reviewed Sep 15, 2025

View reviewed changes

src/upgrade/upgradeManager.ts Outdated Show resolved Hide resolved

FluoriteCafe-work added 4 commits September 15, 2025 15:28

chore: rename java.dependency.enableDependencyDiagnostics

9fa24f9

... to java.dependency.enableDependencyCheckup` as `Diagnostics` is used as a VSCode-specific concept

chore: add operationName in telemetry

1456262

chore: don't collect failureReason

efdff83

chore: rename

2578194

wangmingliang-ms approved these changes Sep 15, 2025

View reviewed changes

FluoriteCafe-work added 2 commits September 15, 2025 16:18

chore: don't show the commands in CP

731d86a

chore: fix lint

803be9b

FluoriteCafe-work requested review from chagong and testforstephen September 15, 2025 09:02

wangmingliang-ms approved these changes Sep 16, 2025

View reviewed changes

FluoriteCafe-work added 3 commits September 16, 2025 11:50

feat: show reasons for the versions we choose

aea445f

feat: update notification display UX

430f7e8

chore: merge getNowTs()

440e92e

jdneo reviewed Sep 16, 2025

View reviewed changes

src/upgrade/display/notificationManager.ts Outdated Show resolved Hide resolved

src/upgrade/upgradeManager.ts Show resolved Hide resolved

FluoriteCafe-work added 2 commits September 16, 2025 15:53

chore(notificationManager): tweak order of shouldShow and hasShown

478d871

chore: workspaceUri -> workspaceFolderUri

4397ccc

jdneo previously approved these changes Sep 16, 2025

View reviewed changes

chore: lint

a0abeb9

FluoriteCafe-work dismissed jdneo’s stale review via a0abeb9 September 16, 2025 09:00

akaroml reviewed Sep 16, 2025

View reviewed changes

FluoriteCafe-work added 2 commits September 16, 2025 17:39

feat: add EOL date to notification

4d271c1

chore: lint

3b09680

FluoriteCafe-work requested a review from akaroml September 17, 2025 03:32

wangmingliang-ms approved these changes Sep 17, 2025

View reviewed changes

jdneo approved these changes Sep 18, 2025

View reviewed changes

FluoriteCafe-work merged commit 465d988 into microsoft:main Sep 18, 2025
4 of 6 checks passed

plnordquist mentioned this pull request Oct 17, 2025

Document how to disable "older runtime" warning #917

Open

Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions #901

Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions #901

Uh oh!

Conversation

FluoriteCafe-work commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FluoriteCafe-work commented Sep 3, 2025

Uh oh!

wangmingliang-ms Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FluoriteCafe-work Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

akaroml left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akaroml left a comment

Choose a reason for hiding this comment

Uh oh!

akaroml left a comment

Choose a reason for hiding this comment

Uh oh!

FluoriteCafe-work commented Sep 10, 2025

Uh oh!

Uh oh!

wangmingliang-ms left a comment

Choose a reason for hiding this comment

Uh oh!

wangmingliang-ms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FluoriteCafe-work commented Sep 3, 2025 •

edited

Loading

wangmingliang-ms Sep 3, 2025 •

edited

Loading

FluoriteCafe-work Sep 3, 2025 •

edited

Loading