Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Multiple tests and comments incorrectly documented Azure Resource ID sanitization as using dash (-) when the implementation uses underscore (_).

Changes

Tests corrected:

  • BaseClusterModel.test.ts: Two test cases now use .replace(/\//g, '_') instead of .replace(/\//g, '-')
  • DiscoveryBranchDataProvider.test.ts: Fixed test to expect error throw (matches implementation) instead of warning

Comments corrected:

  • VCoreBranchDataProvider.ts: Updated inline comment to "replace '/' with '_'"
  • RUBranchDataProvider.ts: Updated inline comment to "replace '/' with '_'"

All changes align with the actual sanitizeAzureResourceIdForTreeId() implementation:

export function sanitizeAzureResourceIdForTreeId(azureResourceId: string): string {
    return azureResourceId.replace(/\//g, '_');  // underscore, not dash
}

These issues were previously marked as resolved but the incorrect documentation remained in the codebase.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Refactor base cluster model architecture for clarity Fix documentation and tests using incorrect sanitization character Jan 30, 2026
Copilot AI requested a review from tnaum-ms January 30, 2026 20:28
…anitization

Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
Copilot AI changed the title Fix documentation and tests using incorrect sanitization character Fix Azure Resource ID sanitization documentation and tests Jan 30, 2026
@tnaum-ms tnaum-ms marked this pull request as ready for review January 30, 2026 20:41
@tnaum-ms tnaum-ms requested a review from a team as a code owner January 30, 2026 20:41
@tnaum-ms tnaum-ms merged commit fecd231 into dev/tnaum/refactor-base-cluster-model-architecture Jan 30, 2026
2 checks passed
@tnaum-ms tnaum-ms deleted the copilot/sub-pr-473 branch January 30, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants