-
Notifications
You must be signed in to change notification settings - Fork 8
fix: maintain connections after a connection move. clusterId and treeId are now separate #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tnaum-ms
wants to merge
44
commits into
next
Choose a base branch
from
dev/tnaum/move-connection-protection
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eId for identification and clusterId for credential caching
…clusterId for stable connections across folder moves
…ing to use clusterId for consistency across commands
…reeId and clusterId
…se stable clusterId for credential lookups across various contexts
…cation by using stable connection identifiers for task checks
…ion to use stable clusterId for consistency
…r ID across views
…s to avoid path separator issues
…ing and connection management
…tion for resource IDs
…rity and separation of concerns
…onnections and database items
…ure proper sanitization of resource IDs
… models and tests
…ptimize resource routing
…timize cluster ID handling
…uster tree elements
…th cluster ID validation and augmentation
…d improve cluster ID handling
…ssary provider ID extraction and enhancing cluster node lookup
…ation and improve tree ID extraction
…lidation in Discovery services
…ts for simplification
…om a specific parent
… to replace '/' with '_' for consistency across models
…anitization Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
…stead of hyphen Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
…ed classes and interfaces - Updated AzureMongoRUSubscriptionItem, AzureSubscriptionItem, and AzureVMResourceItem to use 'azureResourceId' instead of 'id' for Azure Resource ID. - Modified AzureVMResourceItem tooltip to reflect the change in property name. - Refactored DocumentDbDocumentReader to use 'clusterId' instead of 'connectionId' for consistency. - Changed resource usage helper and task service to use 'clusterId' in place of 'connectionId'. - Updated tests to reflect the new 'clusterId' naming convention. - Enhanced tree data providers to include methods for finding cluster nodes by 'clusterId'. - Adjusted various service and model files to ensure consistent usage of 'azureResourceId' and 'clusterId'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.