Skip to content

fix: trim connection strings to ensure valid inputs #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnaum-ms merged 2 commits into from
Jan 29, 2026
Merged

fix: trim connection strings to ensure valid inputs #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
855c2fa
fix: trim connection strings to ensure valid inputs
tnaum-ms Jan 27, 2026
42e11eb
Merge branch 'next' into dev/tnaum/trim-connection-string
tnaum-ms Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions l10n/bundle.l10n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@
"Connecting to the cluster using Entra ID…": "Connecting to the cluster using Entra ID…",
"connection \"{0}\"": "connection \"{0}\"",
"Connection String": "Connection String",
"Connection string cannot be empty.": "Connection string cannot be empty.",
"Connection string is not set": "Connection string is not set",
"Connection updated successfully.": "Connection updated successfully.",
"Connection: \"{selectedConnectionName}\"\n\nThe connection will be added to the \"Connections View\" in the \"DocumentDB for VS Code\" extension. The \"Connections View\" will be opened once this process completes.\n\nDo you want to continue?": "Connection: \"{selectedConnectionName}\"\n\nThe connection will be added to the \"Connections View\" in the \"DocumentDB for VS Code\" extension. The \"Connections View\" will be opened once this process completes.\n\nDo you want to continue?",
Expand Down
8 changes: 8 additions & 0 deletions src/commands/newConnection/PromptConnectionStringStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ export class PromptConnectionStringStep extends AzureWizardPromptStep<NewConnect

//eslint-disable-next-line @typescript-eslint/require-await
private async validateConnectionString(connectionString: string): Promise<string | null | undefined> {
connectionString = connectionString ? connectionString.trim() : '';

if (connectionString.length === 0) {
return l10n.t('Invalid Connection String: {error}', {
error: l10n.t('Connection string cannot be empty.'),
});
}

try {
new DocumentDBConnectionString(connectionString);
} catch (error) {
Expand Down