Skip to content

Add warning for removeConnection invoked with no selection #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnaum-ms merged 2 commits into from
Nov 24, 2025
Merged

Add warning for removeConnection invoked with no selection #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c3d328
Initial plan
Copilot Nov 21, 2025
962c762
Add warning message for empty connection selection in removeConnection
Copilot Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions l10n/bundle.l10n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@
"No Azure VMs found with tag \"{tagName}\" in subscription \"{subscriptionName}\".": "No Azure VMs found with tag \"{tagName}\" in subscription \"{subscriptionName}\".",
"No collection selected.": "No collection selected.",
"No commands found in this document.": "No commands found in this document.",
"No connections selected to remove.": "No connections selected to remove.",
"No Connectivity": "No Connectivity",
"No credentials found for id {credentialId}": "No credentials found for id {credentialId}",
"No credentials found for the selected cluster.": "No credentials found for the selected cluster.",
Expand Down
1 change: 1 addition & 0 deletions src/commands/removeConnection/removeConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export async function removeConnection(
}

if (connectionsToDelete.length === 0) {
ext.outputChannel.warn(l10n.t('No connections selected to remove.'));
return;
}

Expand Down