Fix custom comment continuation for multiple follow-up lines#14076
Merged
sean-mcmanus merged 3 commits intomainfrom Dec 5, 2025
Merged
Fix custom comment continuation for multiple follow-up lines#14076sean-mcmanus merged 3 commits intomainfrom
sean-mcmanus merged 3 commits intomainfrom
Conversation
Contributor
|
@bobbrow There's a bug whenever one begin pattern is a prefix of another, e.g. if This works correctly, "C_Cpp.commentContinuationPatterns": [
{
"begin": "/*!",
"continue": " ! "
}
],but adding a "/*" breaks it (uses "C_Cpp.commentContinuationPatterns": [
"/*",
{
"begin": "/*!",
"continue": " ! "
}
],similarly, "//" is used as the continue for "///". I could file a new bug for that (it's a pre-existing bug and not a regression from this PR). |
sean-mcmanus
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8998
Cherry-picks the original change from the release branch. It should have gone to main first.
Also adds a unit test.