put standard library file associations in package.json#14002
Conversation
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Can you add the missing extensionless system headers?
ccomplex
cfenv
cinttypes
contracts
cstdalign
cstdbool
cstdint
ctgmath
cuchar
debugging
hazard_pointer
hive
inplace_vector
linalg
rcu
simd
text_encoding
|
Is this for 1.28.3? Or 1.29.0? Seems like 1.29.0 might be better...I was worried about something breaking regarding the language handling. |
|
Does this change potentially break something contributed by VS Code itself and/or should the change be made in VS Code itself? |
|
What about the other "languages" fields like "aliases" and "configuration" -- should those be set? Does VS Code set those and/or do we inherit those if we don't set the fields? |
Yes. It looks like I did not include headers removed since their introduction and new C++26 headers. |
|
VS Code uses Do you know how to check if that is still inherited? |
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Should we add the GSL library extensionless files? VS has those added (maybe others?).
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Should we generate/update this list of filenames by reading a shared file with VS which also has a similar list of extension less files? We could do that similar to the import-edge-strings script.
Or otherwise, should it manually match VS?
We can consider it for the future. I'll open an issue.
It's not really a priority for me to support every library that decided to go extensionless (eigen is another one). I think it's a bad practice to go extensionless because it is harder for tooling, but I'm biased because I work on the tooling. 😄 |
* put standard library file associations in package.json (#14002) * Fix incorrect comma in settings string. (#14005) * Update IntelliSense strings (translations are available yet). (#14020) * Enable setting the VS dev environment without running from Dev Command Prompt (#13571) * For VS 18.0 and above, use "Insiders" instead of "Preview" (#14022) * Adding telemetry for devcmd environment usage (#14023) * Update changelog and version for 1.29.0. (#14028) * Update changelog and version for 1.29.0. * Update TPN. (#14029) * Update changelog (2nd time). (#14032) * Update IntelliSense loc strings. (#14038) * Update localization (#14039) * Localization - Translated Strings * Some fixes. * Remove \t. --------- Co-authored-by: csigs <csigs@users.noreply.github.com> * Update the msvc version to 1950. (#14042) * Retry build files task in cg.yml (#14043) * Retry build files. * Update changelog for 1.29.1. (#14058) * Bump js-yaml from 4.1.0 to 4.1.1 in /Extension (#14060) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update js-yaml for github actions. (#14061) * Fix typo "no_suitable_complier" in nativeStrings.json (#14064) * Update changelog and verison for 1.29.2. (#14070) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com> Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dhruvil Shah <dshah4@ncsu.edu>
2 participants
Fixes: #4077
This change disables
C_Cpp.autoAddFilesAssociationsby default and lists the standard headers inpackage.jsonto associate them with C++. Other extensionless headers will not get special treatment, but their languageId will still be fixed when a goto definition command is handled.