Fix infinite ssh config file include processing.#13971
Merged
sean-mcmanus merged 4 commits intomainfrom Sep 30, 2025
Merged
Conversation
Contributor
Author
|
Copilot found a bug/problem with this fix. It appears there are valid cases of repeated includes. |
…/microsoft/vscode-cpptools into seanmcm/fixSshIncludesProcessing
Colengms
approved these changes
Sep 30, 2025
Contributor
Author
|
I'm working on a follow up to add activation progress telemetry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13966 .
The fix was created by Copilot, but I had to fix it up by deleting unnecessary changes. But then Copilot found a bug with the fix upon review, but it was able to create a fix.
I tested this via using the repro for the bug, plus 8 .conf files that Copilot generated (not checked in).