You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Aligns some hard-coded default file associations with the defaults on the native side. (There is a separate native PR for fixes there).
Fixes a bug where .C may be considered a C source file (uppercase implies C++).
Correctly considers .i a C source file, and .ii a C++ source file. Added missing header type: .tlh, .tli
Moves .tcc to the list of header files instead of source files.
Not addressed by this PR: These functions should also consider the contents of files.assocations (at least for source file types, as that does not distinguish between headers and sources).
Is this universally true? I recently preprocessed a .cpp file with MSVC and it spit out a .i for me.
It looks like MSVC incorrectly copied the convention from GCC/clang, and doesn't properly use .ii for C++ sources. However, if you look at the native PR, at the changes in settings.h, you'll see that we were already considering .i a C file. (Apparently because VS Code itself considers .i a C source file, which you can confirm by opening one).
It looks like MSVC incorrectly copied the convention from GCC/clang, and doesn't properly use .ii for C++ sources. However, if you look at the native PR, at the changes in settings.h, you'll see that we were already considering .i a C file. (Apparently because VS Code itself considers .i a C source file, which you can confirm by opening one).
I'm not particularly worried about it since I don't think there are any existing bugs asking for different behavior. It seems to be an uncommon scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns some hard-coded default file associations with the defaults on the native side. (There is a separate native PR for fixes there).
Fixes a bug where
.Cmay be considered a C source file (uppercase implies C++).Correctly considers
.ia C source file, and.iia C++ source file. Added missing header type:.tlh,.tliMoves
.tccto the list of header files instead of source files.Not addressed by this PR: These functions should also consider the contents of
files.assocations(at least for source file types, as that does not distinguish between headers and sources).