Closed
Conversation
| "Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered." | ||
| ] | ||
| }, | ||
| "c_cpp.configuration.reduceRecursiveIncludes.markdownDescription": "Indicates whether recursive include paths should be reduced to only those currently referenced by the translation unit. If enabled, performance is impacted if the database needs to be populated to determine headers used. If disabled, performance may be impacted due to passing a large number of include paths to the IntelliSense process.", |
Contributor
There was a problem hiding this comment.
"enabled" and "disabled" should be in markdown/backticks like the other settings value examples.
Contributor
There was a problem hiding this comment.
Or true/false as mentioned in the other thread.
| "type": "boolean", | ||
| "default": true, | ||
| "markdownDescription": "%c_cpp.configuration.reduceRecursiveIncludes.markdownDescription%", | ||
| "scope": "window" |
Contributor
There was a problem hiding this comment.
Shouldn't this have an enum like
"enum": [
"default",
"enabled",
"disabled"
],
I'm not sure if "default" is needed (we could potentially use that to auto-set the default from an experiment).
Contributor
There was a problem hiding this comment.
Oh -- it's a bool -- your description references "enabled"/"disabled"? Should that be true/false instead?
…nto coleng/reduceRecursiveIncludesSetting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding as a fully-fledged setting, for now. If we encounter issues when testing with it set to false, we could hide the setting. Requires the corresponding PR in the language server.