Fix an issue with editorconfig tab_size#13216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
.editorconfigtab_sizenot being applied to VS Code's tab size when in "space" (soft tab) mode.I ran into this with the EDG codebase. (
host_envir.c/.hare much easier to look at now).The new check seems simpler:
indent_styleis applied, only if present, to VS Code'sinsertSpacesoption.indent_sizeis applied to VS Code'sindentSizeANDtabSize(as a fallback/default).tab, VS Code'sindentSizeoption is set to its own special value oftabSize(telling VS Code to use the value oftabSizeinstead).tab_widthis specified, it's applied to VS Code'stabSizeoption.Based on information here: