Merge latest Library.Template#1450
Merged
Merged
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (519) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (520) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…earch (#513) * Fix Install-DotNetSdk.ps1 hang from recursive Directory.Build.props search The Get-ChildItem call applied -Recurse to all three path arguments, including Directory.Build.props. PowerShell splits this into container + leaf filter, so -Recurse causes it to search the entire repo root for every file named Directory.Build.props, crawling into large directories (bin, obj, tmp, etc.) and causing the script to hang. Split the call so -Recurse only applies to the src/ and test/ project file globs. Directory.Build.props is fetched with Get-Item -LiteralPath (single file, no recursion, no wildcard interpretation). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Recursively search src/ and test/ for Directory.Build.props Address review feedback: keep recursive Directory.Build.props discovery under src/ and test/, while still picking up the repo-root file. Avoids crawling top-level bin/obj/tmp directories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: drognanar <3418274+drognanar@users.noreply.github.com>
Resolve Directory.Packages.props merge conflicts by taking incoming template updates while preserving repo-specific settings: - Update MicrosoftTestingPlatformVersion to 2.2.3 from template - Keep MessagePackVersion property used by this repo - Update PolySharp to 1.16.0 while preserving DisablePolyfills condition used by test project
There was a problem hiding this comment.
Pull request overview
This PR updates repository build/test infrastructure to align with the latest Library.Template, primarily via dependency/tool version bumps and a PowerShell script fix to avoid a hang when scanning MSBuild props.
Changes:
- Bump Microsoft Testing Platform to
2.2.3and update related tooling/dependencies (code coverage + PolySharp). - Update local dotnet tools to
powershell 7.6.2anddotnet-coverage 18.7.0. - Fix
tools/Install-DotNetSdk.ps1project/props discovery to avoid a recursiveDirectory.Build.propssearch that can hang.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tools/Install-DotNetSdk.ps1 |
Refines project/props enumeration to avoid the problematic recursive root Directory.Build.props search. |
Directory.Packages.props |
Central package version bumps (MTP, CodeCoverage, PolySharp) consistent with template update goals. |
.config/dotnet-tools.json |
Updates pinned tool versions for pwsh and dotnet-coverage to match the template/tooling refresh. |
SylviaLe191
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.