fix(spector): handle matchers in query param validation#10259
Open
fix(spector): handle matchers in query param validation#10259
Conversation
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/97f0d4fc-38c9-455c-b99d-f9dd980c6658 Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/97f0d4fc-38c9-455c-b99d-f9dd980c6658 Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
microsoft-github-policy-service
bot
added
spector
Copilot created this pull request from a session on behalf of
weidongxu-microsoft
April 3, 2026 02:16
View session
|
|
||
| if (apiDefinition.request?.query) { | ||
| const query = expandDyns(apiDefinition.request.query, config); | ||
| const query = expandDyns(apiDefinition.request.query, config, { resolveMatchers: false }); |
Contributor
There was a problem hiding this comment.
Agent says the expandDyns with resolveMatchers: true converts the smart matcher into a dumb string too early, discarding its comparison logic. resolveMatchers: false keeps the matcher alive long enough for deepEqual → matchValues → matcher.check() to perform the semantic comparison.
…gh expandDyns Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/3d8e85a8-9e45-4d55-9f8c-7882641b3c27 Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
Contributor
|
For PR #10011 agent session https://github.com/microsoft/typespec/tasks/467970f4-8e4b-4bab-b0fb-6d9774b72753?author=weidongxu-microsoft (analyze is on my local Copilot CLI) tested locally by directly modify the js file in test project node_modules |
Comment on lines
+247
to
+260
| it("should demonstrate why resolveMatchers:true (default) breaks semantic query param matching", () => { | ||
| // With the default resolveMatchers:true, the matcher is eagerly converted to a plain string. | ||
| // A strict string comparison then fails for semantically equivalent but format-different values. | ||
| const queryDef = { input: match.dateTime.utcRfc3339("2022-08-26T18:38:00.000Z") }; | ||
| const expandedWithResolve = expandDyns(queryDef, config); // resolveMatchers: true (default) | ||
|
|
||
| // The matcher is gone — replaced by its serialized string | ||
| expect(isMatcher(expandedWithResolve.input)).toBe(false); | ||
| expect(expandedWithResolve.input).toBe("2022-08-26T18:38:00.000Z"); | ||
|
|
||
| // Strict string comparison fails for an equivalent datetime without milliseconds | ||
| expect(expandedWithResolve.input === "2022-08-26T18:38:00Z").toBe(false); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
I asked copilot to add test, but these may not be very meaningful. I can revert them if unhelpful.
Member
There was a problem hiding this comment.
yeah that make sense, wondering if we ever need the resolveMatchers: true on. i'll investigate in a folllow up pr
commit: |
…gression test Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/05805cb9-1d23-42fd-8b80-fd06410b09dc Co-authored-by: weidongxu-microsoft <53292327+weidongxu-microsoft@users.noreply.github.com>
weidongxu-microsoft
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
Collaborator
|
You can try these changes here
|
timotheeguerin
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveMatchers: false+isMatcherbranch)resolveMatchers: falseand addisMatcher(value)branch