Accept baseline: declaration emit simplification of class extending built-in Array#3780
Open
Accept baseline: declaration emit simplification of class extending built-in Array#3780
Conversation
…uilt-in Array Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Simplify declaration emit for class extending built-in Array
Accept baseline: declaration emit simplification of class extending built-in Array
May 8, 2026
RyanCavanaugh
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates submodule baseline classifications by moving javascriptThisAssignmentInStaticBlock.js.diff from “triaged” to “accepted”, reflecting that the current JS declaration emit difference is considered non-blocking for parity tracking.
Changes:
- Removed
compiler/javascriptThisAssignmentInStaticBlock.js.difffromtestdata/submoduleTriaged.txt. - Added
compiler/javascriptThisAssignmentInStaticBlock.js.difftotestdata/submoduleAccepted.txtunder “emit differences of no consequence”. - Added the corresponding accepted baseline diff at
testdata/baselines/reference/submoduleAccepted/compiler/javascriptThisAssignmentInStaticBlock.js.diff.
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the diff from the triaged list (but currently leaves an empty section header). |
| testdata/submoduleAccepted.txt | Adds the diff to the accepted list under the appropriate category. |
| testdata/baselines/reference/submoduleAccepted/compiler/javascriptThisAssignmentInStaticBlock.js.diff | Provides the accepted baseline diff content for the moved entry. |
Copilot's findings
Comments suppressed due to low confidence (1)
testdata/submoduleTriaged.txt:199
- This section is now empty after moving the diff to submoduleAccepted. Please remove the leftover header and issue link (and the trailing blank line) so submoduleTriaged.txt doesn’t accumulate empty sections.
# Declaration emit simplification of class extending built-in Array
## https://github.com/microsoft/typescript-go/issues/3569
- Files reviewed: 2/3 changed files
- Comments generated: 0
jakebailey
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts the
javascriptThisAssignmentInStaticBlock.js.diffbaseline. Corsa's JS declaration emitter produces better output here:extends Array<any>→extends Array—<any>is implied in expression positionstatic doSomething/static isArraynow emitted — static blockthisassignments are properly bound and checkedMoved diff from
submoduleTriagedtosubmoduleAcceptedunder "emit differences of no consequence".