Skip to content

Accept baseline: declaration emit simplification of class extending built-in Array#3780

Open
Copilot wants to merge 2 commits intomainfrom
copilot/simplify-class-extending-array
Open

Accept baseline: declaration emit simplification of class extending built-in Array#3780
Copilot wants to merge 2 commits intomainfrom
copilot/simplify-class-extending-array

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

Accepts the javascriptThisAssignmentInStaticBlock.js.diff baseline. Corsa's JS declaration emitter produces better output here:

  • extends Array<any>extends Array<any> is implied in expression position
  • Inherited constructor overloads removed — no longer copying unnecessary base class signatures
  • static doSomething / static isArray now emitted — static block this assignments are properly bound and checked

Moved diff from submoduleTriaged to submoduleAccepted under "emit differences of no consequence".

…uilt-in Array

Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot AI changed the title [WIP] Simplify declaration emit for class extending built-in Array Accept baseline: declaration emit simplification of class extending built-in Array May 8, 2026
Copilot AI requested a review from RyanCavanaugh May 8, 2026 21:28
@RyanCavanaugh RyanCavanaugh marked this pull request as ready for review May 8, 2026 23:12
Copilot AI review requested due to automatic review settings May 8, 2026 23:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates submodule baseline classifications by moving javascriptThisAssignmentInStaticBlock.js.diff from “triaged” to “accepted”, reflecting that the current JS declaration emit difference is considered non-blocking for parity tracking.

Changes:

  • Removed compiler/javascriptThisAssignmentInStaticBlock.js.diff from testdata/submoduleTriaged.txt.
  • Added compiler/javascriptThisAssignmentInStaticBlock.js.diff to testdata/submoduleAccepted.txt under “emit differences of no consequence”.
  • Added the corresponding accepted baseline diff at testdata/baselines/reference/submoduleAccepted/compiler/javascriptThisAssignmentInStaticBlock.js.diff.
Show a summary per file
File Description
testdata/submoduleTriaged.txt Removes the diff from the triaged list (but currently leaves an empty section header).
testdata/submoduleAccepted.txt Adds the diff to the accepted list under the appropriate category.
testdata/baselines/reference/submoduleAccepted/compiler/javascriptThisAssignmentInStaticBlock.js.diff Provides the accepted baseline diff content for the moved entry.

Copilot's findings

Comments suppressed due to low confidence (1)

testdata/submoduleTriaged.txt:199

  • This section is now empty after moving the diff to submoduleAccepted. Please remove the leftover header and issue link (and the trailing blank line) so submoduleTriaged.txt doesn’t accumulate empty sections.
# Declaration emit simplification of class extending built-in Array
## https://github.com/microsoft/typescript-go/issues/3569

  • Files reviewed: 2/3 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baselines: Declaration emit simplification of class extending built-in Array

4 participants