Accept late-bound computed property baseline diffs#3779
Open
Accept late-bound computed property baseline diffs#3779
Conversation
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix late-bound computed property preservation issue
Accept late-bound computed property baseline diffs
May 8, 2026
RyanCavanaugh
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Accepts two submodule baseline diffs as “won’t-fix” by moving them from the triaged set to the accepted set, reflecting known (non-semantic) declaration emit differences in tsgo vs TypeScript.
Changes:
- Removed the two late-bound computed property diffs from
testdata/submoduleTriaged.txt. - Added the same diffs to
testdata/submoduleAccepted.txt. - Added accepted baseline
.difffiles undertestdata/baselines/reference/submoduleAccepted/compiler/.
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the two entries from the triaged list (but leaves an empty header block). |
| testdata/submoduleAccepted.txt | Adds the two entries to the accepted list (currently without a dedicated rationale block for #3566). |
| testdata/baselines/reference/submoduleAccepted/compiler/lateBoundMethodNameAssigmentJS.js.diff | New accepted baseline diff for late-bound method name case. |
| testdata/baselines/reference/submoduleAccepted/compiler/lateBoundAssignmentCandidateJS2.js.diff | New accepted baseline diff for late-bound assignment candidate case. |
Copilot's findings
- Files reviewed: 2/4 changed files
- Comments generated: 2
Comment on lines
188
to
190
| # Late-bound computed property [prop] preserved instead of resolved to plain prop | ||
| ## https://github.com/microsoft/typescript-go/issues/3566 | ||
| compiler/lateBoundAssignmentCandidateJS2.js.diff | ||
| compiler/lateBoundMethodNameAssigmentJS.js.diff | ||
|
|
| @@ -1388,3 +1388,5 @@ conformance/nodeModulesDeclarationEmitWithPackageExports(module=nodenext).errors | |||
| ## JSDoc module namepath module:A emits as unresolved module instead of any | |||
| ## https://github.com/microsoft/typescript-go/issues/3562 | |||
| conformance/jsDeclarationsModuleReferenceHasEmit(target=es2015).js.diff | |||
jakebailey
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline Acceptance
Accepts baseline diffs for
lateBoundAssignmentCandidateJS2.jsandlateBoundMethodNameAssigmentJS.jsas won't-fix.tsgo emits
[prop]instead ofpropin declaration output because it traverses input nodes (which use bracket syntax) rather than synthesizing types from symbol information. Both emits are semantically equivalent.submoduleTriaged/→submoduleAccepted/submoduleAccepted.txtandsubmoduleTriaged.txtaccordingly