Accept symbolDeclarationEmit12.js baseline change#3778
Open
Conversation
…leAccepted Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update baselines for symbol getter/setter declaration emit
Accept symbolDeclarationEmit12.js baseline change
May 8, 2026
RyanCavanaugh
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the symbolDeclarationEmit12.js declaration-emit baseline from “triaged” to “accepted”, reflecting that Corsa’s output for this case is now considered the correct/intentional divergence from the submodule baseline.
Changes:
- Remove
conformance/symbolDeclarationEmit12.js.difffromtestdata/submoduleTriaged.txt. - Add
conformance/symbolDeclarationEmit12.js.difftotestdata/submoduleAccepted.txt. - Add the corresponding accepted reference baseline diff under
testdata/baselines/reference/submoduleAccepted/....
Show a summary per file
| File | Description |
|---|---|
| testdata/submoduleTriaged.txt | Removes the triaged entry for symbolDeclarationEmit12.js.diff (leaves an empty section header). |
| testdata/submoduleAccepted.txt | Adds symbolDeclarationEmit12.js.diff to the accepted list. |
| testdata/baselines/reference/submoduleAccepted/conformance/symbolDeclarationEmit12.js.diff | Adds the accepted reference diff showing the intended declaration emit change. |
Copilot's findings
- Files reviewed: 2/3 changed files
- Comments generated: 1
Comment on lines
193
to
195
| # Symbol getter/setter declaration emit change | ||
| ## https://github.com/microsoft/typescript-go/issues/3567 | ||
| conformance/symbolDeclarationEmit12.js.diff | ||
|
|
jakebailey
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corsa's declaration emit for
symbolDeclarationEmit12is more correct than strada's. Strada had a bug where it confused getter and method return types for[Symbol.toPrimitive]and incorrectly elided the method overload viaisImplementationOfOverload. Since the input has duplicate declarations, the output should too.conformance/symbolDeclarationEmit12.js.difffromsubmoduleTriaged→submoduleAccepted