Port checks for tslib helpers

[gabritto]

Fixes #3476.

We also had some accepted baselines that are no longer accepted, because as far as I could tell we do still use the emit helpers. That check used to be gated on esModuleInterop being true, but now it's always true so we always do the checks.
As far as I could verify, we still use all of the helpers checked in this PR in emit.

I had to change requestedExternalEmitHelpers to be cached per-file instead of per module symbol, since caching it on the module symbol meant you'd get less diagnostics if a checker happened to check two files with the error, but more diagnostics if two different checkers (and therefore module symbols) checked those two files. The accepted baselines are for this reason.

[Copilot]

Pull request overview

This PR ports TypeScript’s --importHelpers / tslib helper validation into the Go checker so missing or incompatible helpers are consistently diagnosed, and updates the submodule baseline/triage lists accordingly (Fixes #3476).

Changes:

• Add per-source-file caching and expanded helper-bit tracking for external emit helper checks in the checker.
• Add new helper checks across async/for-await/destructuring/decorators/private names/module transforms to match emitted-helper requirements.
• Update accepted/triaged lists and rebaseline affected submodule test outputs now that helper diagnostics are produced.

Reviewed changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
testdata/submoduleTriaged.txt	Removes the tslib-helper issue block now that behavior is implemented.
testdata/submoduleAccepted.txt	Drops outdated accepted baselines and adds new accepted cases for per-file helper checking.
testdata/baselines/reference/submoduleTriaged/conformance/usingDeclarationsWithImportHelpers.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/privateNameStaticEmitHelpers.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/privateNameEmitHelpers.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions3(module=nodenext,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions3(module=node20,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions3(module=node18,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions3(module=node16,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions2(module=nodenext).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions2(module=node20).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions2(module=node18).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions2(module=node16).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions(module=nodenext).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions(module=node20).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions(module=node18).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesImportHelpersCollisions(module=node16).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=nodenext,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=node20,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=node18,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=node16,target=es2015).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=nodenext).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=node20).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=node18).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=node16).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=nodenext).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=node20).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=node18).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=node16).errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/exportAsNamespace_missingEmitHelpers.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/conformance/awaitUsingDeclarationsWithImportHelpers.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/compiler/tslibNotFoundDifferentModules.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/compiler/tslibMultipleMissingHelper.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleTriaged/compiler/tslibMissingHelper.errors.txt.diff	Removes triaged diff (now matches reference).
testdata/baselines/reference/submoduleAccepted/compiler/tslibMultipleMissingHelper.errors.txt.diff	New accepted diff reflecting per-file helper diagnostics.
testdata/baselines/reference/submoduleAccepted/compiler/tslibMissingHelper.errors.txt.diff	New accepted diff reflecting per-file helper diagnostics.
testdata/baselines/reference/submoduleAccepted/compiler/importHelpersWithImportOrExportDefaultNoTslib.3(esmoduleinterop=true,module=commonjs).errors.txt.diff	Removes outdated accepted diff.
testdata/baselines/reference/submoduleAccepted/compiler/importHelpersWithImportOrExportDefaultNoTslib.2(esmoduleinterop=true,module=commonjs).errors.txt.diff	Removes outdated accepted diff.
testdata/baselines/reference/submoduleAccepted/compiler/importHelpersWithImportOrExportDefaultNoTslib.1(esmoduleinterop=true,module=commonjs).errors.txt.diff	Removes outdated accepted diff.
testdata/baselines/reference/submoduleAccepted/compiler/importHelpersES6.errors.txt.diff	Removes outdated accepted diff.
testdata/baselines/reference/submoduleAccepted/compiler/esModuleInteropTslibHelpers.errors.txt.diff	Removes outdated accepted diff.
testdata/baselines/reference/submoduleAccepted/compiler/ctsFileInEsnextHelpers.errors.txt.diff	Removes outdated accepted diff.
testdata/baselines/reference/submodule/conformance/usingDeclarationsWithImportHelpers.errors.txt	Adds updated reference baseline with tslib missing-helper error.
testdata/baselines/reference/submodule/conformance/privateNameStaticEmitHelpers.errors.txt	Adds updated reference baseline with tslib arity mismatch errors.
testdata/baselines/reference/submodule/conformance/privateNameEmitHelpers.errors.txt	Adds updated reference baseline with tslib arity mismatch errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions3(module=nodenext,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions3(module=node20,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions3(module=node18,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions3(module=node16,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions2(module=nodenext).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions2(module=node20).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions2(module=node18).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions2(module=node16).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions(module=nodenext).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions(module=node20).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions(module=node18).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesImportHelpersCollisions(module=node16).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=nodenext,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=node20,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=node18,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions3(module=node16,target=es2015).errors.txt	Adds updated reference baseline with tslib helper missing error.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=nodenext).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=node20).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=node18).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions2(module=node16).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=nodenext).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=node20).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=node18).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsImportHelpersCollisions1(module=node16).errors.txt	Adds updated reference baseline with tslib helper missing errors.
testdata/baselines/reference/submodule/conformance/exportAsNamespace_missingEmitHelpers.errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/conformance/awaitUsingDeclarationsWithImportHelpers.errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/compiler/tslibNotFoundDifferentModules.errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/compiler/tslibMultipleMissingHelper.errors.txt	Adds updated reference baseline with multiple missing helper errors.
testdata/baselines/reference/submodule/compiler/tslibMissingHelper.errors.txt	Adds updated reference baseline with per-file missing helper errors.
testdata/baselines/reference/submodule/compiler/importHelpersWithImportOrExportDefaultNoTslib.3(esmoduleinterop=true,module=commonjs).errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/compiler/importHelpersWithImportOrExportDefaultNoTslib.2(esmoduleinterop=true,module=commonjs).errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/compiler/importHelpersWithImportOrExportDefaultNoTslib.1(esmoduleinterop=true,module=commonjs).errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/compiler/importHelpersES6.errors.txt	Adds updated reference baseline with tslib missing-module error.
testdata/baselines/reference/submodule/compiler/esModuleInteropTslibHelpers.errors.txt	Adds updated reference baseline with tslib missing-module errors.
testdata/baselines/reference/submodule/compiler/ctsFileInEsnextHelpers.errors.txt	Adds updated reference baseline with tslib missing-module error.
internal/transformers/estransforms/namedevaluation.go	Switches named-evaluation source detection to shared AST utility functions.
internal/printer/helpers.go	Removes outdated section comment near helper definitions.
internal/checker/utilities.go	Adds outer-expression parent walk helper for named evaluation checks.
internal/checker/types.go	Introduces ExternalEmitHelpers bitmask and adds per-file helper/module caches to SourceFileLinks.
internal/checker/checker.go	Implements and wires helper checks across relevant syntax/features and adds module/helper resolution logic.
internal/ast/utilities.go	Adds IsNamedEvaluationSource and IsProtoSetter utilities for reuse across packages.

[gabritto]

This was a bug in Strada which is now fixed.

[gabritto]

I'm convinced this was dead code. I removed it and added a test and everything still works.

[jakebailey]

This seems 1:1 but I think the copilot comments are worth addresssing