Accept CJS export alias and element access pattern baseline diffs#3771
Draft
Accept CJS export alias and element access pattern baseline diffs#3771
Conversation
Move moduleExportAliasElementAccessExpression, moduleExportDuplicateAlias, moduleExportDuplicateAlias2, moduleExportDuplicateAlias3, and moduleExportsElementAccessAssignment .js.diff files from submoduleTriaged to submoduleAccepted. Corsa correctly emits string literal export names in declaration output instead of mangling them to identifiers, which is more correct behavior. Fixes #3545 Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CJS export alias and element access patterns
Accept CJS export alias and element access pattern baseline diffs
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Enhancement
What does this improve?
Accepts 5 baseline diffs where Corsa's declaration emit is more correct than Strada's. Strada mangled non-identifier export names (e.g.
export { D as _Does_not_work_yet }) while Corsa correctly preserves string literal export names (e.g.export { D as "Does not work yet" }), matching runtime semantics.Implementation approach:
submoduleTriaged.txt→submoduleAccepted.txtwith explanatory commentsubmoduleTriaged/→submoduleAccepted/Affected baselines:
conformance/moduleExportAliasElementAccessExpression.js.diffconformance/moduleExportDuplicateAlias.js.diffconformance/moduleExportDuplicateAlias2.js.diffconformance/moduleExportDuplicateAlias3.js.diffconformance/moduleExportsElementAccessAssignment.js.diff