Skip to content

Fix custom tsgo path: read from js/ts.tsdk.path unified setting#3765

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/fix-custom-tsgo-path-issue
Draft

Fix custom tsgo path: read from js/ts.tsdk.path unified setting#3765
Copilot wants to merge 3 commits intomainfrom
copilot/fix-custom-tsgo-path-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026 •
edited
Loading

getExe() only read from typescript.native-preview.tsdk, ignoring the unified js/ts.tsdk.path setting. Users configuring a custom tsgo binary via the unified setting would always get the bundled binary instead.

  • Added getExplicitTsdkPath() helper that checks js/ts.tsdk.path first, then falls back to typescript.native-preview.tsdk
  • Uses inspect() to distinguish workspace-level vs global-level values, preserving the existing workspace trust gate
  • Follows the same unified config precedence pattern used by readUnifiedConfig and getExplicitUseTsgo elsewhere in the extension
// Both of these now correctly resolve to the custom binary:
"js/ts.tsdk.path": "./.vscode/.bin/tsgo_pnp/"
"typescript.native-preview.tsdk": "./.vscode/.bin/tsgo_pnp/"

Copilot AI linked an issue May 8, 2026 that may be closed by this pull request
custom tsgo path is now ignored #3722
Open
Copilot AI and others added 2 commits May 8, 2026 03:24
@jakebailey
Fix custom tsgo path: also read from js/ts.tsdk.path unified setting
8da404f 
The getExe() function only read from `typescript.native-preview.tsdk`
but ignored the unified `js/ts.tsdk.path` setting. This caused the
extension to always use the bundled tsgo binary even when a custom
path was configured via the unified setting.

Now getExe() checks `js/ts.tsdk.path` first (with precedence), then
falls back to `typescript.native-preview.tsdk`, following the same
unified config pattern used elsewhere in the extension.

Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/3d3ea93c-c6f0-4010-9ed2-f62800d93aed

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
@jakebailey
Remove unused _workspaceOnly parameter from getExplicitTsdkPath
af3dd2b 
Agent-Logs-Url: https://github.com/microsoft/typescript-go/sessions/3d3ea93c-c6f0-4010-9ed2-f62800d93aed

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix custom tsgo path being ignored Fix custom tsgo path: read from js/ts.tsdk.path unified setting May 8, 2026
Copilot AI requested a review from jakebailey May 8, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey jakebailey Awaiting requested review from jakebailey

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@jakebailey jakebailey

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

custom tsgo path is now ignored

2 participants

@jakebailey