Fixes a crash when renaming import path of a JSON file#3196
Open
Andarist wants to merge 1 commit intomicrosoft:mainfrom
Open
Fixes a crash when renaming import path of a JSON file#3196Andarist wants to merge 1 commit intomicrosoft:mainfrom
Andarist wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Andarist
commented
Mar 22, 2026
Comment on lines
+1383
to
+1385
| if options.use == referenceUseRename && ast.IsSourceFile(decl) { | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I have tested the same patch in Strada and renaming the from "./x/package.json" resulted in the file itself being renamed too. That's definitely a desirable outcome but I'm not exactly sure what's the codepath leading to that filename rename - given it works... I wasn't exactly inclined to dig deeper.
The alternative fix would be to handle this in the loop here:
typescript-go/internal/ls/rename.go
Lines 82 to 92 in a4325da
The crash happens in getTextForRename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a crash found here #3187 (comment) (it also crashes in Strada)