Skip to content

API encode/decode fixes#3195

Open
virtulis wants to merge 9 commits intomicrosoft:mainfrom
virtulis:object-literal-fix
Open

API encode/decode fixes#3195
virtulis wants to merge 9 commits intomicrosoft:mainfrom
virtulis:object-literal-fix

Conversation

@virtulis
Copy link

@virtulis virtulis commented Mar 21, 2026

  1. Added a number of missing node properties for the API encoder/decoder on both ends.
  2. Added the token type for the HeritageClause, as far as I understand the bit usage is arbitrary per kind, so just used the first one.
  3. Changed isTypeNode to also return true on type keywords, list copied from KeywordTypeSyntaxKind. These appear as is in parser output, which is probably correct?

All of these were hit mostly by just doing roundtrips of some test code between the parser and emitter via the API and getSynthesizedDeepClone. Probably a bunch more to be found that way.

@virtulis
Copy link
Author

@microsoft-github-policy-service agree

@virtulis virtulis changed the title Object literal fix API encode/decode fixes Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant