Merged
Conversation
jakebailey
commented
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the repository’s Go toolchain target to Go 1.26 and updates generated fourslash tests to stop using PtrTo/ptrTo, instead using new(...) for pointer construction.
Changes:
- Update Go version references across
go.mod, tooling modules, and developer docs/configs to Go 1.26. - Regenerate/adjust fourslash completion tests to replace
PtrTo(...)(and related util dot-imports) withnew(...). - Update internal fourslash utilities to use
new(...)instead ofptrTo(...).
Reviewed changes
Copilot reviewed 300 out of 537 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/fourslash/tests/gen/completionsUniqueSymbol_import_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsUniqueSymbol1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsTypeOnlyNamespace_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsTuple_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsSymbolMembers_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsRedeclareModuleAsGlobal_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsRecommended_union_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsRecommended_switch_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsRecommended_namespace_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsRecommended_equals_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsPropertiesWithPromiseUnionType_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsPropertiesPriorities_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingProperties1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethodCrash1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod9_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod4_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod17_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod14_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod11_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOverridingMethod10_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsOptionalKindModifier_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsObjectLiteralWithPartialConstraint_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsObjectLiteralMethod6_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsNamespaceMergedWithClass_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsLiterals_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsKeywordsExtends_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsJsxExpression_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsJsxAttributeInitializer2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsJsdocTypeTagCast_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsJsdocTag_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsJSDocNoCrash3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsInterfaceElement_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsIndexSignatureConstraint1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsInJsxTag_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsInExport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsInExport_moduleBlock_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsInExport_invalid_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_windowsPathsProjectRelative_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_weirdDefaultSynthesis_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImport_uriStyleNodeCoreModules2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_uriStyleNodeCoreModules1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_umdModules3_script_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_umdModules2_moduleExports_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_umdModules1_globalAccess_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_umdDefaultNoCrash1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_typeOnly_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImport_tsx_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_sortingModuleSpecifiers_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_shadowedByLocal_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_require_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_require_addToExisting_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_require_addNew_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_reExport_wrongName_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_reExportDefault2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_quoteStyle_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImport_previousTokenIsSemicolon_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_preferUpdatingExistingImport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_packageJsonImportsPreference_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_ofAlias_preferShortPath_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_noSemicolons_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImport_named_namespaceImportExists_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_named_fromMergedDeclarations_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_named_exportEqualsNamespace_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_named_exportEqualsNamespace_merged_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_named_didNotExistBefore_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_named_addToNamedImports_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_multipleWithSameName_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_mergedReExport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_jsxOpeningTagImportDefault_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_jsModuleExportsAssignment_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_importType_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_fromAmbientModule_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImport_filteredByPackageJson_peerDependencies_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_filteredByPackageJson_nested_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_filteredByPackageJson_direct_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_filteredByPackageJson_@typesOnly_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_filteredByPackageJson_@typesImplicit_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_filteredByInvalidPackageJson_direct_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_exportEquals_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_exportEquals_global_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_exportEquals_anonymous_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_exportEqualsNamespace_noDuplicate_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_duplicatePackages_types_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_duplicatePackages_typesAndNotTypes_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_duplicatePackages_scoped_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_duplicatePackages_scopedTypes_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_duplicatePackages_scopedTypesAndNotTypes_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_details_withMisspelledName_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImport_default_symbolName_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_reExport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_fromMergedDeclarations_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_exportDefaultIdentifier_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_didNotExistBefore_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_anonymous_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_alreadyExistedWithRename_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_addToNamespaceImport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_default_addToNamedImports_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_defaultFalsePositive_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_compilerOptionsModule_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_augmentation_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_ambient_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_addToNamedWithDifferentCacheValue_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImport_46332_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImportYieldExpression_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImportTypeKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImportPathsConflict_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImportModuleAugmentationWithJS_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImportFromJSXTag_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsImportDefaultExportCrash2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsImportBaseUrl_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsGenericUnconstrained_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsGenericTypeWithMultipleBases1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsGenericIndexedAccess5_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsGenericIndexedAccess4_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsGenericIndexedAccess3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsGeneratorFunctions_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsExportImport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsElementAccessNumeric_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsDotInArrayLiteralInObjectLiteral_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/completionsDefaultKeywordWhenDefaultExportAvailable_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsDefaultExport_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsClassMemberImportTypeNodeParameter4_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsClassMemberImportTypeNodeParameter3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsClassMemberImportTypeNodeParameter2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsClassMemberImportTypeNodeParameter1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsAugmentedTypesClass2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsAssertKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsAfterLessThanToken_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsAfterKeywordsInBlock_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionsAfterJSDoc_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionWithNamespaceInsideFunction_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionWithDotFollowedByNamespaceKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionUsingKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionSatisfiesKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionReturnConstAssertion_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionPropertyShorthandForObjectLiteral5_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionOfInterfaceAndVar_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionOfAwaitPromise7_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionOfAwaitPromise5_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionOfAwaitPromise3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionOfAwaitPromise2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionOfAwaitPromise1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionNoAutoInsertQuestionDotForTypeParameter_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionNoAutoInsertQuestionDotForThis_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListWithUnresolvedModule_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListStaticProtectedMembers3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListStaticMembers_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListOnPrivateVariableInModule_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListOnAliases_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListOnAliases2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListOfUnion_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListOfGenericSymbol_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListObjectMembers_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListObjectMembersInTypeLocationWithTypeof_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInvalidMemberNames_withExistingIdentifier_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInvalidMemberNames_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInvalidMemberNames_startWithSpace_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInvalidMemberNames_escapeQuote_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInsideTargetTypedFunction_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInferKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInUnclosedObjectTypeLiteralInSignature04_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInObjectLiteral8_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInObjectLiteral6_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInNamedFunctionExpressionWithShadowing_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInNamedFunctionExpression1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInNamedClassExpression_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInNamedClassExpressionWithShadowing_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInImportClause04_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInImportClause03_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInImportClause02_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInExtendsClause_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInExportClause03_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInExportClause02_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInExportClause01_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInClosedObjectTypeLiteralInSignature04_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInClassStaticBlocks_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListInClassExpressionWithTypeParameter_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListForRest_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListForObjectSpread_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListForGenericInstance1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListForExportEquals_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListForExportEquals2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListForDerivedType1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListClassThisJS_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListClassMembers_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListCladule_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListAtEndOfWordInArrowFunction03_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListAtEndOfWordInArrowFunction02_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListAfterStringLiteral1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListAfterRegularExpressionLiteral1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionListAfterRegularExpressionLiteral01_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionInUncheckedJSFile_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionInJsDoc_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionInJsDocQualifiedNames_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionInJSDocFunctionThis_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionInJSDocFunctionNew_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionInFunctionLikeBody_includesPrimitiveTypes_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForStringLiteral_quotePreference8_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForStringLiteral_quotePreference7_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForStringLiteral_quotePreference3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForStringLiteral_quotePreference2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForObjectProperty_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForMetaProperty_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionForComputedStringProperties_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionExportFrom_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryOnNarrowedType_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryForUnionProperty_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryForUnionProperty2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryForShorthandPropertyAssignment_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryForPropertyFromUnionOfModuleType_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryForConst_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionEntryClassMembersWithInferredFunctionReturnType1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionCloneQuestionToken_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionBeforeSemanticDiagnosticsInArrowFunction1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionAutoInsertQuestionDot_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionAsKeyword_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/completionAfterQuestionDot_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/commentsEnumsFourslash_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/codeCompletionEscaping_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/cloduleTypeOf1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/cloduleAsBaseClass_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/cloduleAsBaseClass2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportVerbatimTypeOnly1_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/gen/autoImportTypeOnlyPreferred1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportSpecifierExcludeRegexes1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportSortCaseSensitivity2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportSameNameDefaultExported_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportReExportFromAmbientModule_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_wildcardExports3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_wildcardExports2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_wildcardExports1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_namespaceSameNameAsIntrinsic_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_globalTypingsCache_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap9_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap8_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap7_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap6_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap5_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap4_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider_exportMap1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider8_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider7_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportProvider6_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportPathsAliasesAndBarrels_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportModuleNone2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportFileExcludePatterns3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportFileExcludePatterns2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportCompletionExportListAugmentation4_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportCompletionExportListAugmentation3_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportCompletionExportListAugmentation2_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportCompletionExportListAugmentation1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportCompletionExportEqualsWithDefault1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/autoImportCompletionAmbientMergedModule1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/augmentedTypesClass3Fourslash_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/augmentedTypesClass1_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/gen/argumentsAreAvailableAfterEditsAtEndOfFunction_test.go | Replace PtrTo(...) with new(...) in generated completion expectations |
| internal/fourslash/tests/exhaustiveCaseCompletions11_test.go | Replace PtrTo(...) with new(...) in completion snippet expectation |
| internal/fourslash/tests/exhaustiveCaseCompletions10_test.go | Replace PtrTo(...) with new(...) in capabilities and expectation |
| internal/fourslash/tests/completionsInJsxTag_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/completionResolveKeyword_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/tests/completionFilterText4_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/completionFilterText2_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/completionDetailSignature_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/completionClassMembersAfterConstAssertionInitializer_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/basicMultifileCompletions_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/basicJSDocCompletions_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/basicInterfaceMembers_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/basicEdit_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/autoImportTransitiveLeak_test.go | Replace PtrTo(...) with new(...) in completion expectations |
| internal/fourslash/tests/autoImportQuoteDetection_test.go | Remove util dot-import and replace PtrTo(...) with new(...) |
| internal/fourslash/baselineutil.go | Replace ptrTo(...) usages with new(...) in internal slicing/index helper |
| go.mod | Bump module Go version to 1.26 |
| _tools/go.mod | Bump tools module Go version to 1.26 |
| _tools/customlint/testdata/go.mod | Bump customlint testdata Go version to 1.26 |
| CONTRIBUTING.md | Update stated minimum Go version to 1.26 |
| .github/actions/setup-go/action.yml | Update default Go version used by setup action to go1.26 |
| .dprint.jsonc | Update gofumpt language version to go1.26 |
| .devcontainer/devcontainer.json | Update devcontainer image to Go 1.26 variant |
| .custom-gcl.yml | Bump custom-gcl version from v2.8.0 to v2.9.0 |
gabritto
approved these changes
Feb 11, 2026
Member
Author
|
This came out quite literally yesterday; I'm not sure when the right time to do this is given it's not in the Arch Linux repos, longsleep PPA, homebrew. |
Member
What consequences could this have? Just contributors not being able to build tsgo? |
Member
Author
Well, with The worst case is that |
gabritto
approved these changes
Feb 11, 2026
Member
Author
|
Also, on my laptop, |
Member
Author
|
On my desktop: 
|
Member
Author
|
A downside is that tinygo doesn't have Go 1.26 yet, and I like to test things with it, but it's also broken for other reasons anyway. So probably not a blocker. |
Member
Author
|
brew has Go 1.26. That's enough for me to feel comfortable merging this; GOTOOLCHAIN will work fine for the rest. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably, compiling tsgo itself takes 30% less time, and
ptrTois now gone, asnewperforms that same task in the language itself.