Update CHANGES.md to reflect #2513 #2541
Open
+11
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CHANGES.md documentation to reflect the implementation of issue #2513, which relates to handling CommonJS exports initialized to undefined. The changes primarily reorganize and update documentation about implemented features and behavior changes.
Changes:
- Removed "Features yet to be implemented" section for
Object.definePropertyon CommonJS exports (now implemented) - Updated @typedef/@callback behavior description to reflect hoisting semantics
- Replaced removed CommonJS limitations with documentation about the new
undefinedinitialization pattern support
CHANGES.md
Outdated
| #### Initializing exports to `undefined`: | ||
|
|
||
| If you can't configure your package to use ESM syntax, you can use destructuring instead: | ||
| To accomodate the pattern of initializing CommonJS exports to `undefined` (sometimes written as `void 0`) and then subseqently assigning their intended values, when CommonJS exports have multiple assignments and an initial assignment of `undefined`, the `undefined` is ignored when determining the type of the export. |
There was a problem hiding this comment.
Spelling error: "subseqently" should be spelled "subsequently".
Suggested change
| To accomodate the pattern of initializing CommonJS exports to `undefined` (sometimes written as `void 0`) and then subseqently assigning their intended values, when CommonJS exports have multiple assignments and an initial assignment of `undefined`, the `undefined` is ignored when determining the type of the export. | |
| To accomodate the pattern of initializing CommonJS exports to `undefined` (sometimes written as `void 0`) and then subsequently assigning their intended values, when CommonJS exports have multiple assignments and an initial assignment of `undefined`, the `undefined` is ignored when determining the type of the export. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RyanCavanaugh
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.