feat: detect deprecated via JSDoc and flag deprecated property access #2524
+15
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the deprecated property access check in
internal/checker/checker.go, resolving a TODO comment. The implementation translates the logic from the TypeScript compiler to Go.Additionally, it updates
IsDeprecatedDeclarationto fallback to checkinggetJSDocDeprecatedTag, ensuring robust detection even ifNodeFlagsDeprecatedis not set.internal/checker/checker.go:
checkPropertyAccessExpressionOrQualifiedName.deprecatedNode.IsDeprecatedDeclarationto check JSDoc tags.Compilation:
go build ./cmd/tsgopasses.Manual Testing: Tested with a
@deprecatedproperty.Observation: The check logic is correct, but the currently implemented Parser does not yet attach JSDoc comments to AST nodes, so
getJSDocDeprecatedTagreturnsnil. This feature will automatically become active once JSDoc parsing support is added upstream.