Exit LSP process if parent process stops existing #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the LSP specification requirement to exit the language server process when the parent process (typically the editor) terminates. This helps prevent orphaned tsgo processes when editors crash or are killed unexpectedly.
Changes:
- Added a callback mechanism to set the parent process ID during server initialization
- Implemented a watchdog goroutine that periodically checks if the parent process is still alive
- Integrated platform-specific process checking logic for Unix and Windows systems
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/lsp/server.go | Added SetParentProcessId callback field to ServerOptions and Server struct; invokes the callback during handleInitialize when processId is provided |
| cmd/tsgo/lsp.go | Implemented parent process watchdog with periodic polling and platform-specific process existence checking |
Member
|
If the parent process no longer exists, won't we get an EOF on standard input or something? |
Member
Author
|
Yeah, I guess that's probably the case... |
Member
|
#2499 might explain why an EOF was not sufficient for shutting down. |
jakebailey
commented
Jan 14, 2026
| return | ||
| } | ||
| go func() { | ||
| tick := time.Tick(5 * time.Second) |
Member
Author
There was a problem hiding this comment.
This is a random amount of time. I don't know what the right number is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP spec says to exit if the parent process exits.
Add a callback to the server code to set the parent process ID, then periodically check to see if we should exit.
Might help with some of the "tsgo is staying open", but not so much in cases where "restart" is used. But, good to do what the spec says.