Move PointerId, focus and in-bounds handling down into Interactivity#20017
Merged
carlos-zamora merged 2 commits intomainfrom Mar 31, 2026
Merged
Move PointerId, focus and in-bounds handling down into Interactivity#20017carlos-zamora merged 2 commits intomainfrom
carlos-zamora merged 2 commits intomainfrom
Conversation
These do not notionally belong to TermControl; as we prepare to move automatic scrolling down into the Interactivity layer (for WpfTerminalControl to depend on,) we're going to need to track these in Interactivity too. This also converts the arguments from the winrt-specific Foundation::Point to Core::Point, and simplifies some of the signatures to no longer pass things we do not need to pass. Right now, this should result in no functional change.
| } | ||
|
|
||
| void ControlInteractivity::PointerPressed(Control::MouseButtonState buttonState, | ||
| void ControlInteractivity::PointerPressed(const uint32_t /*pointerId*/, |
Member
There was a problem hiding this comment.
Curious: what's the plan for pointerId when we do use it?
Member
Author
There was a problem hiding this comment.
Well! Autoscroll uses it!
when we move autoscroll down into the interactivity layer, it needs to know which pointer moved out-of-frame and caused the scroll
carlos-zamora
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These do not notionally belong to TermControl; as we prepare to move automatic scrolling down into the Interactivity layer (for WpfTerminalControl to depend on,) we're going to need to track these in Interactivity too.
This also converts the arguments from the winrt-specific Foundation::Point to Core::Point, and simplifies some of the signatures to no longer pass things we do not need to pass.
Right now, this should result in no functional change.
Some of the tests are sensitive to the fact that we never loaded
SPI_GETWHEELSCROLLLINESand instead defaulted to
1. They've been hammered back into shape.