chore: bump core version to 1.0.3-preview and remove offsets#540
Open
singhk97 wants to merge 1 commit into
Open
chore: bump core version to 1.0.3-preview and remove offsets#540singhk97 wants to merge 1 commit into
singhk97 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
singhk97
force-pushed
the
bump/core-1.0.3-preview
branch
from
8f012af to
2bb2c9d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates core Nerdbank.GitVersioning configuration to move core packages to a new preview versioning scheme and remove versionHeightOffset usage.
Changes:
- Bumps
core/version.jsonto a1.0.x-preview.{height}version string and removesversionHeightOffset. - Removes
versionHeightOffsetfromcore/src/Microsoft.Teams.Apps/version.jsonwhile keeping its existing2.1.0-preview.{height}base.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/version.json | Sets new core preview version string and removes versionHeightOffset. |
| core/src/Microsoft.Teams.Apps/version.json | Removes versionHeightOffset from the Apps sub-tree versioning config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json", | ||
| "version": "1.0", | ||
| "versionHeightOffset": -6, | ||
| "version": "1.0.4-preview.{height}", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/version.jsonto1.0.3-preview.{height}versionHeightOffsetfrom bothcore/version.jsonandcore/src/Microsoft.Teams.Apps/version.json🤖 Generated with Claude Code