Update breaking changes doc #523
Open
MehakBindra wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the breaking-changes reduction plan documentation for core/src/Microsoft.Teams.Apps by reorganizing the inventory into “Pending”, “Doc-only”, “Not migrated”, and “Implemented” sections, and by recording which compatibility gaps are already addressed in the new core library.
Changes:
- Reorganized the breaking-changes inventory into status-based sections and updated several entries to “IMPLEMENTED” with the corresponding fix notes and file locations.
- Added/updated sample migration difficulty assessment to reflect remaining blockers only.
- Clarified several architectural/documentation-only items and consolidated “review later” gaps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+279
to
+283
| var appBuilder = App.Builder() | ||
| .AddLogger(new ConsoleLogger(...)) | ||
| .AddOAuth("graph"); | ||
| builder.AddTeams(appBuilder); | ||
| ``` |
Comment on lines
+293
to
309
| **Decision: IMPLEMENTED** — parameterless overload on `WebApplicationBuilder` | ||
|
|
||
| ### Item 5: Add `App.Builder()` wrapper around ASP.NET DI | ||
| - **Impact:** Resolves BC-6, unblocks Graph and Meetings samples | ||
| - **Details:** `App.Builder()` returns a builder that wraps standard ASP.NET DI options pattern. | ||
| **Old API:** | ||
| ```csharp | ||
| builder.AddTeams(); // on WebApplicationBuilder | ||
| builder.AddTeams(appBuilder); // with App.Builder | ||
| ``` | ||
|
|
||
| ### Item 6: Add `OnMeetingJoin`/`OnMeetingLeave` aliases | ||
| - **File:** `core/src/Microsoft.Teams.Apps/Handlers/MeetingExtensions.cs` | ||
| - **Impact:** Resolves BC-10 | ||
| - **Details:** Aliases to `OnMeetingParticipantJoin`/`OnMeetingParticipantLeave`. No `[Obsolete]` for now. | ||
| **New API:** | ||
| ```csharp | ||
| builder.Services.AddTeams(); // on IServiceCollection | ||
| ``` | ||
|
|
||
| ### Item 7: Add proactive `Send()`/`Reply()` on TeamsBotApplication | ||
| - **File:** `core/src/Microsoft.Teams.Apps/TeamsBotApplication.cs` or extension | ||
| - **Impact:** Resolves BC-8, unblocks Threading sample | ||
| **Samples affected:** All | ||
|
|
||
| ### Item 8: Add `InvokeResponse.Ok()`/`InvokeResponse.Error()` factory methods | ||
| - **Impact:** Resolves BC-12 | ||
| - **File:** Invoke response types in core project | ||
| **Fix applied:** Parameterless `AddTeams(this WebApplicationBuilder builder)` extension method added, delegating to `builder.Services.AddTeams()`. | ||
|
|
|
|
||
| **Infrastructure events (architectural change):** | ||
| - `OnActivity`, `OnError`, `OnStart`, `OnActivityResponse`, `OnActivitySent` | ||
| Not migrated (low priority): `WithSummary()`, `WithDeliveryMode()`, `Merge()`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.