Skip to content

CI/CD - Fix Image build for cuda11.1.1 and py unit test pipelines #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polarG wants to merge 13 commits into
base: main
Choose a base branch
from
+20 −4
Open

CI/CD - Fix Image build for cuda11.1.1 and py unit test pipelines #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
05a89a6
Anchor wandb version when python is 3.8.
Jan 6, 2026
af676fc
Adopt new api.
Jan 7, 2026
5a4d01e
Fix lint issues.
Jan 7, 2026
22fd5f5
Fix lint issues.
Jan 7, 2026
0080d92
Revert wandb changes.
Jan 12, 2026
059daa9
Remove cuda11.1.1.
Jan 12, 2026
7f6de0c
Revert "Remove cuda11.1.1."
Jan 13, 2026
4f23173
Install go in cuda11.1.1 dockerfile.
Jan 13, 2026
5bf14d4
Revert "Install go in cuda11.1.1 dockerfile."
Jan 13, 2026
0687eec
Anchor wandb to 0.22.3 when python < 3.12.
Jan 13, 2026
ae05143
Add wandb version control for python >= 3.12.
Jan 13, 2026
1ecbcda
Add build dependencies of wandb in 11.1.1 to build wandb, instead of …
Jan 13, 2026
8e8d286
Fix comments.
Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions dockerfile/cuda11.1.1.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ RUN apt-get update && \
automake \
bc \
build-essential \
ca-certificates \
curl \
dmidecode \
ffmpeg \
Expand All @@ -46,6 +47,7 @@ RUN apt-get update && \
openssh-client \
openssh-server \
pciutils \
software-properties-common \
sudo \
util-linux \
vim \
Expand All @@ -55,6 +57,19 @@ RUN apt-get update && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/* /opt/cmake-3.14.6-Linux-x86_64

# Install Go (used for wandb build)
RUN add-apt-repository -y ppa:longsleep/golang-backports && \
apt-get update && \
apt-get install -y golang-1.24-go
Comment on lines +61 to +63
Copy link
Member

@abuccts abuccts Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge it with existing apt-get command

Copy link
Contributor Author

@polarG polarG Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'add-apt-repository' is installed with 'software-properties-common' in the first RUN. So, we cannot combine it with the first apt-get.

Copy link
Member

@abuccts abuccts Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add-apt-repository after the apt-get install, before apt-get autoremove and clean
why do you need two different stages for apt-get? why do you need to run apt-get update after apt-get clean?


# Install Rust (used for wandb build)
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y && \
. /root/.cargo/env && \
rustup update stable && \
rustup default stable

ENV PATH="/usr/lib/go-1.24/bin:/root/.cargo/bin:${PATH}"
Copy link
Member

@abuccts abuccts Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge with existing env command

Copy link
Contributor Author

@polarG polarG Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous environment lacks Go and Cargo installations, and the subsequent environment is configured specifically for Docker workflows. Given this separation of concerns, I believe we should maintain the current configuration. Please let me know if you'd like any modifications.

Copy link
Member

@abuccts abuccts Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean? why do you need two different stages to set PATH env?
can you change ENV PATH="${PATH}" \ in line 122 to ENV PATH="${PATH}:/usr/lib/go..." \?


ARG NUM_MAKE_JOBS=

# Install Docker
Expand Down
9 changes: 5 additions & 4 deletions superbench/benchmarks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,11 @@ def _process_percentile_result(self, metric, result, reduce_type=None):
if len(result) > 0:
percentile_list = ['50', '90', '95', '99', '99.9']
for percentile in percentile_list:
self._result.add_result(
'{}_{}'.format(metric, percentile),
np.percentile(result, float(percentile), interpolation='nearest'), reduce_type
)
try:
val = np.percentile(result, float(percentile), method='nearest')
Copy link
Contributor

@guoshzhao guoshzhao Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need update this? Have you met some failure?

Copy link
Contributor Author

@polarG polarG Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I met it after the changes for wandb. In PR, this also appeared.

'interpolation' was deprecated in v1.22.0 and removed on 2.4.0. In the python3.12 unit test pipeline, v2.4.1 was installed.

Comment on lines +296 to +297
Copy link
Member

@abuccts abuccts Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you open another pr for this?

Copy link
Contributor Author

@polarG polarG Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we move this to another PR, the python-unit-test will fail in this PR.

Copy link
Member

@abuccts abuccts Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't you open another PR to merge to current branch?

except TypeError:
val = np.percentile(result, float(percentile), interpolation='nearest')
Comment on lines +296 to +299
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The try-except approach is too broad for version detection. Since TypeError could occur for other reasons, consider checking NumPy version explicitly at module level or using a more specific exception check. For example, use hasattr(np.percentile, '__wrapped__') or check np.__version__ to determine which parameter to use.

Copilot uses AI. Check for mistakes.
self._result.add_result('{}_{}'.format(metric, percentile), val, reduce_type)

def print_env_info(self):
"""Print environments or dependencies information."""
Expand Down
Loading