Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Jan 31, 2026

For providers which don't natively support score threshold, I've gone with applying the filter client-side - the other option would be to throw.

  • In EF we're quite strict on not bringing back database data in order to client-evaluate; in other words, if the user wants to load database rows from the database and then perform some post-filtering, they need to write that explicitly in code, to avoid scenarios where tons of data gets unintentionally transferred.
  • In MEVD we already implement Skip in various providers by bringing back the entire matching resultset and then filtering client-side. This is potentially much worse than filtering for score threshold client-side, as the amount of extra data brought back by threshold post-filtering is limited to top (k), whereas with Skip/pagination queries that amount of data grows with each page.
  • Ultimately, MEVD is simpler and more high-level, and is also explicitly designed for layers to be composed on top (e.g. MEDI). So there does seem to be more value in features "just working" across providers.

Closes #9566

@moonbox3 moonbox3 added the .NET Issue or Pull requests regarding .NET code label Jan 31, 2026
@github-actions github-actions bot changed the title [MEVD] Implement support for score threshold .Net: [MEVD] Implement support for score threshold Jan 31, 2026
@moonbox3 moonbox3 added python Pull requests for the Python Semantic Kernel kernel Issues or pull requests impacting the core kernel labels Jan 31, 2026
@github-actions github-actions bot changed the title .Net: [MEVD] Implement support for score threshold Python: .Net: [MEVD] Implement support for score threshold Jan 31, 2026
@moonbox3
Copy link
Collaborator

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
core_plugins/sessions_python_tool
   sessions_python_plugin.py1781293%100, 124, 126–127, 129, 131, 133, 141, 215–216, 250–251
TOTAL28130482582% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3812 23 💤 0 ❌ 0 🔥 1m 45s ⏱️

@moonbox3 moonbox3 removed python Pull requests for the Python Semantic Kernel kernel Issues or pull requests impacting the core kernel labels Jan 31, 2026
@roji roji changed the title Python: .Net: [MEVD] Implement support for score threshold .Net: [MEVD] Implement support for score threshold Jan 31, 2026
@roji roji marked this pull request as ready for review January 31, 2026 14:21
@roji roji requested a review from a team as a code owner January 31, 2026 14:21
@roji roji enabled auto-merge January 31, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.Net: VectorStore: Add ability to filter results by the similarity score

2 participants