[rush] cobuilds: yield priority to other tasks in the queue#5741
Open
aramissennyeydd wants to merge 2 commits intomicrosoft:mainfrom
Open
[rush] cobuilds: yield priority to other tasks in the queue#5741aramissennyeydd wants to merge 2 commits intomicrosoft:mainfrom
aramissennyeydd wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
aramissennyeydd
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
Contributor
Author
|
@dmichon-msft Curious your thoughts here - we're seeing much longer cobuilds than we expect and I think it's related to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#4821 updated the behavior of cobuilds such that large weight operations (such as those that lock and entire agent) do not get skipped while they're remote executing. Instead, they force the agent that's waiting on them to continue reading their state (with only a 500ms window to pick up another task). This PR attempts to improve operation scheduling by moving tasks that are currently cobuilding to the back of the queue and let other tasks go in front.
Details
I don't love the API addition here, happy to update as needed. Just wanted to plumb through the idea of moving an operation to the back of the queue. This could also be done on
Operation.statuschange automatically.How it was tested
Added unit tests. Would love to get a preview version to test on our internal repo.
Impacted documentation