Prevent multiple text models when there are multiple parsers. #3261
+117
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…corresponding tests
BryanValverdeU
requested review from
JiuqingSong,
Copilot,
flyingbee2012,
ianeli1,
juliaroldi and
vinguyen12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where multiple text format parsers caused duplicate text segments to be added to the model. The fix moves the internalTextProcessor call outside the forEach loop so it's only called once after all parsers have modified the segment format.
Changes:
- Moved
internalTextProcessorcall outside theforEachloop intextProcessor.tsto prevent duplicate segment creation - Added three new test cases to verify correct behavior with multiple parsers, empty parser arrays, and parsers that modify the segment format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/roosterjs-content-model-dom/lib/domToModel/processors/textProcessor.ts | Fixed bug by moving internalTextProcessor call outside the parser loop |
| packages/roosterjs-content-model-dom/test/domToModel/processors/textProcessorTest.ts | Added comprehensive test coverage for multiple parsers scenario and edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JiuqingSong
approved these changes
Jan 17, 2026
…pleTextFormatParsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are more than 2 format parsers, we call internalTextProcessor more than once, which causes that we add more segments into the model.
To fix move the internalTextProcessor function call outside of the for loop