Insert table content #3258
Open
Insert table content #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
reviewed
Jan 16, 2026
| editor.formatContentModel( | ||
| (model, context) => { | ||
| const insertPosition = deleteSelection(model, [], context).insertPoint; | ||
| const copiedModel = cloneModel(model); |
Collaborator
There was a problem hiding this comment.
curious why we need to clone a model?
Contributor
Author
There was a problem hiding this comment.
I used the cloned model, because it returns the content model types, not readonly types, making it easier to insert the content into the table that is ContentModelTable type.
| } | ||
|
|
||
| if (path.length == 1 && block) { | ||
| table.rows[index].cells[0].blocks = [block]; |
Collaborator
There was a problem hiding this comment.
what if only part of a block is selected? Do we still expect to insert the whole block into table?
JiuqingSong
reviewed
Jan 16, 2026
| } | ||
| } | ||
|
|
||
| function insertTableContent( |
Collaborator
There was a problem hiding this comment.
This looks more like a model API, so you can create a separate file under modelAPI folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting a table in a range selection, insert the selected content inside the table.
