fix(align-deps): add React Native type profiles#4182
Closed
vivekjm wants to merge 1 commit into
Closed
Conversation
JasonVMo
approved these changes
Jun 2, 2026
Collaborator
JasonVMo
left a comment
There was a problem hiding this comment.
One note is whether we should add @types/react support as well.
Member
|
I don't think we've decided whether having types in the profiles is a thing we want to maintain. For one, it means that we'll have to provide types for all packages, not just React and React Native. Second, do we want to put types behind a flag for users who don't want them? For now, I'm going to close this PR until we figure out how we want to approach this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types/react-nativealign-deps capability for React Native 0.61 through 0.70@types/react-nativeas a dev-only dependency for those versionsFixes #269.
Test Plan
PATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps test test/capabilities.test.tsPATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps test test/manifest.test.tsPATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps testPATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps buildNote:
yarn change:check --since origin/maincould not run in this checkout because the local Yarn dependency map is missingoxlint@npm:1.61.0; I added the required Changesets entry manually.