Skip to content

fix(align-deps): add React Native type profiles#4182

Closed
vivekjm wants to merge 1 commit into
microsoft:mainfrom
vivekjm:add-types-react-native-profile
Closed

fix(align-deps): add React Native type profiles#4182
vivekjm wants to merge 1 commit into
microsoft:mainfrom
vivekjm:add-types-react-native-profile

Conversation

@vivekjm
Copy link
Copy Markdown
Contributor

@vivekjm vivekjm commented May 30, 2026

Summary

  • add a types/react-native align-deps capability for React Native 0.61 through 0.70
  • make React Native core profiles resolve @types/react-native as a dev-only dependency for those versions
  • stop resolving the community type package starting with the 0.71 profile, where React Native ships its own TypeScript declarations
  • update capability, manifest, set-version, and snapshot coverage

Fixes #269.

Test Plan

  • PATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps test test/capabilities.test.ts
  • PATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps test test/manifest.test.ts
  • PATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps test
  • PATH="$HOME/.nvm/versions/node/v22.22.0/bin:$PATH" yarn workspace @rnx-kit/align-deps build

Note: yarn change:check --since origin/main could not run in this checkout because the local Yarn dependency map is missing oxlint@npm:1.61.0; I added the required Changesets entry manually.

Copy link
Copy Markdown
Collaborator

@JasonVMo JasonVMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note is whether we should add @types/react support as well.

@tido64
Copy link
Copy Markdown
Member

tido64 commented Jun 3, 2026

I don't think we've decided whether having types in the profiles is a thing we want to maintain. For one, it means that we'll have to provide types for all packages, not just React and React Native. Second, do we want to put types behind a flag for users who don't want them? For now, I'm going to close this PR until we figure out how we want to approach this.

@tido64 tido64 closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

align-deps profiles: add a few more dependencies to the profiles

3 participants