Skip to content

Fix NativeModule templates to work with clang #15917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoates-ms merged 2 commits into from
Apr 2, 2026
+18 −8
Merged

Fix NativeModule templates to work with clang #15917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bebbc0
Fix NativeModule templates to work with clang
acoates-ms Apr 2, 2026
81af0d7
Change files
acoates-ms Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-660aa91b-ff55-4316-a3db-b8910ba99e8c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix NativeModule templates to work with clang",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
17 changes: 10 additions & 7 deletions vnext/Microsoft.ReactNative.Cxx/ModuleRegistration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,23 @@
// The macros below are internal implementation details for macro defined in nativeModules.h
//

// ADL-based fallback: returns false for any type not tagged by the macros below.
// Using ADL instead of explicit template specialization allows the macros to be
// used inside a namespace (explicit specializations of a global template must
// occur at global scope, which the macros cannot guarantee).
template <typename T>
struct IsReactTurboModule;
constexpr bool ReactIsReactTurboModuleImpl(T *) noexcept {
return false;
}

// Default to false if no specific override
template <typename T>
struct IsReactTurboModule : std::false_type {};
struct IsReactTurboModule : std::bool_constant<ReactIsReactTurboModuleImpl(static_cast<T *>(nullptr))> {};

#define INTERNAL_REACT_MODULE_REGISTRATION_AND_PROVIDER( \
moduleStruct, moduleName, eventEmitterName, isReactTurboModule) \
struct moduleStruct; \
\
template <> \
struct IsReactTurboModule<moduleStruct> : std::isReactTurboModule##_type {}; \
constexpr bool ReactIsReactTurboModuleImpl(moduleStruct *) noexcept { return isReactTurboModule; } \
\
template <class TDummy> \
struct moduleStruct##_ModuleRegistration final : winrt::Microsoft::ReactNative::ModuleRegistration { \
Expand Down Expand Up @@ -70,8 +74,7 @@ struct IsReactTurboModule : std::false_type {};
moduleStruct, moduleName, eventEmitterName, isReactTurboModule) \
struct moduleStruct; \
\
template <> \
struct IsReactTurboModule<moduleStruct> : std::isReactTurboModule##_type {}; \
constexpr bool ReactIsReactTurboModuleImpl(moduleStruct *) noexcept { return isReactTurboModule; } \
\
template <class TRegistry> \
constexpr void GetReactModuleInfo(moduleStruct *, TRegistry &registry) noexcept { \
Expand Down
2 changes: 1 addition & 1 deletion vnext/Microsoft.ReactNative.Cxx/NativeModules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ struct ModuleEventFieldInfo<TFunc<void(TArgs...)> TModule::*> {
return [module = static_cast<ModuleType *>(module), field](IReactContext const &) noexcept {
// Default emitter will do nothing
// This will be replaced with a method that will call the jsi EventEmitter when JS requests the emitter
module->*field = [](TArgs... args) noexcept {};
module->*field = [](TArgs... /*args*/) noexcept {};
};
} else {
return [module = static_cast<ModuleType *>(module), field, eventName, eventEmitterName](
Expand Down
Loading