fix(ios): add support for react-native-reanimated#1197
Merged
Conversation
9c38a00 to
8d77eaf
Compare
rrebase
reviewed
Nov 14, 2022
rrebase
left a comment
There was a problem hiding this comment.
Tested it out with a different setup and works well 🙌
kelset
approved these changes
Nov 29, 2022
Contributor
kelset
left a comment
There was a problem hiding this comment.
On one hand, I'm as always impressed by the tricks you can pull out of the hat. Very interesting approach to addressing this - I've tested also locally and it works as expected:

My current concern is that this type of workaround is very much custom per each plugin - do we have any docs on this process? Can we make sure that if this approach is the one we want folks to use (and I mean even other devs implementing support for other plugins) is documented at least partially?
Member
Author
|
I will follow up with some docs. I was supposed to document the config-plugins feature, but never got around to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for injecting code into the React bridge delegate, allowing somewhat safer installation of the Reanimated JSI executor.
Resolves #1195.
Platforms affected
Test plan