Fix keyboard focus visibility after Settings in navigation #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes keyboard focus visibility issue when tabbing past the Settings button in the left navigation panel.
Why
When the user pressed Tab on the 'Settings' button (the last item in the left navigation panel), keyboard focus moved to the next focusable element but the focus indicator was not visible anywhere on the screen. Users could not identify where the focus had gone.
Keyboard-only users lost track of navigation flow and were unable to continue interacting with the page. This created confusion, interrupted workflow, and prevented users with motor impairments from completing tasks.
What
handleSettingsKeyDownhandler that cycles focus back to the hamburger menu when Tab is pressed on SettingshandleHamburgerKeyDownhandler that cycles focus to Settings when Shift+Tab is pressed on hamburgerScreenshots
movetabs.mp4
Testing
Microsoft Reviewers: Open in CodeFlow