Fix Context memory leak introduced by PR #3208#3221
Closed
idavis wants to merge 1 commit into
Closed
Conversation
PR #3208 created two unbreakable reference cycles per qdk.Context: - bound-method callbacks passed to the native Interpreter, plus per-callable `_callable_fn` closures that captured `self`, formed Python <-> Rust cycles outside the cyclic GC's reach (PyO3 pyclasses default to no GC integration). - Per-context synthetic namespace modules registered in sys.modules with no cleanup path until the Context was explicitly disposed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3208 created two unbreakable reference cycles per qdk.Context:
_callable_fnclosures that capturedself, formed Python <-> Rust cycles outside the cyclic GC's reach (PyO3 pyclasses default to no GC integration).